[Debian-science-sagemath] <DKIM> Re: <DKIM> Re: <DKIM> Re: flint FTBFS on mips and mipsel

[Julien Puydt]

Hi,

On 17/11/2016 21:04, Julien Puydt wrote:
> On 17/11/2016 17:50, Tobias Hansen wrote:
>> We could try using gcc 5. If all else fails, we can disable the tests on
>> mips.
>
> I'm against the idea to just disable the tests : that will just break
> something else!
>
> I pushed a 2.5.2-13 to git ; what do you think about it? If you find
> that suitable, dch -r and sponsor...

I've been told that -13 breaks with old dpkg-dev, which means jessie and 
ubuntu. jrtc27 suggested on IRC that putting $(PIC_FLAG) last (well, 
after the CFLAGS or CXXFLAGS at least) would solve the issue.

I just prepared a patch doing just that, but I'm going to be mostly 
offline during the week-end, so I won't be able to create a chroot to 
test that fix : as usual, if you have the time before I do, press 
forward. If you don't, that'll just wait...

Cheers,

Snark on #debian-science

PS: I'm starting to find this Zeitnot pretty unconfortable :-/
-------------- next part --------------
Author: Julien Puydt
Description: Put the PIC flags last to avoid breaks with old dpkg-dev
Forward: not-needed

--- a/Makefile.in
+++ b/Makefile.in
@@ -221,7 +221,7 @@
 	$(AT)sed "s/ /,/g;s/.*/&,/g" $< > $@
 
 build/%.lo: %.c $(HEADERS) | build
-	$(QUIET_CC) $(CC) $(PIC_FLAG) $(CFLAGS) $(INCS) -c $< -o $@;
+	$(QUIET_CC) $(CC) $(CFLAGS) $(PIC_FLAG) $(INCS) -c $< -o $@;
 
 build/%.o: %.c $(HEADERS) | build
 	$(QUIET_CC) $(CC) $(CFLAGS) $(INCS) -c $< -o $@;
@@ -236,7 +236,7 @@
 	mkdir -p build/interfaces
 
 build/interfaces/NTL-interface.lo: interfaces/NTL-interface.cpp NTL-interface.h
-	$(QUIET_CXX) $(CXX) $(PIC_FLAG) $(CXXFLAGS) $(INCS) -c $< -o $@
+	$(QUIET_CXX) $(CXX) $(CXXFLAGS) $(PIC_FLAG) $(INCS) -c $< -o $@
 
 build/interfaces/NTL-interface.o: interfaces/NTL-interface.cpp NTL-interface.h
 	$(QUIET_CXX) $(CXX) $(CXXFLAGS) $(INCS) -c $< -o $@
--- a/Makefile.subdirs
+++ b/Makefile.subdirs
@@ -64,7 +64,7 @@
 -include $(LOBJS:.lo=.d)
 
 $(BUILD_DIR)/%.lo: %.c
-	$(QUIET_CC) $(CC) $(PIC_FLAG) $(CFLAGS) $(INCS) -c $< -o $@ -MMD -MP -MF "$(BUILD_DIR)/$*.d" -MT "$(BUILD_DIR)/$*.d" -MT "$@"
+	$(QUIET_CC) $(CC) $(CFLAGS) $(PIC_FLAG) $(INCS) -c $< -o $@ -MMD -MP -MF "$(BUILD_DIR)/$*.d" -MT "$(BUILD_DIR)/$*.d" -MT "$@"
 
 clean:
 	rm -rf $(BUILD_DIR) $(MOD_LOBJ)