[Secure-testing-commits] r2659 - bin

[Joey Hess]

Author: joeyh
Date: 2005-11-04 01:19:19 +0000 (Fri, 04 Nov 2005)
New Revision: 2659

Modified:
   bin/bts-update
Log:
deal with the case where a bug moved from ove CVE id to another, don't
unset the tracked flag last in this case, instead, unset it and then re-set
it.


Modified: bin/bts-update
===================================================================
--- bin/bts-update	2005-11-03 23:34:39 UTC (rev 2658)
+++ bin/bts-update	2005-11-04 01:19:19 UTC (rev 2659)
@@ -30,6 +30,16 @@
 	}
 }
 
+# Remove tags for all old stuff. Hs to come before adding tags for new
+# stuff, to deal with edge cases where bugs move between CVE ids.
+foreach my $bug (keys %old) {
+	foreach my $cve (keys %{$old{$bug}}) {
+		push @changes, "usertag $bug - $cve"
+			unless $cve =~ /CVE-\d+-XXXX/;
+		push @changes, "usertag $bug - tracked";
+	}
+}
+
 # Add tags for all new stuff.
 foreach my $bug (keys %new) {
 	foreach my $cve (keys %{$new{$bug}}) {
@@ -39,15 +49,6 @@
 	}
 }
 
-# Remove tags for all old stuff.
-foreach my $bug (keys %old) {
-	foreach my $cve (keys %{$old{$bug}}) {
-		push @changes, "usertag $bug - $cve"
-			unless $cve =~ /CVE-\d+-XXXX/;
-		push @changes, "usertag $bug - tracked";
-	}
-}
-
 if (system("cp", $list, $oldlist) != 0) {
 	die "failed to copy $list to $oldlist, didn't send any mail";
 }