[Secure-testing-commits] r1765 - bin

[Joey Hess]

Author: joeyh
Date: 2005-09-01 19:29:08 +0000 (Thu, 01 Sep 2005)
New Revision: 1765

Modified:
   bin/checklist
Log:
make warning and strict safe


Modified: bin/checklist
===================================================================
--- bin/checklist	2005-09-01 18:22:38 UTC (rev 1764)
+++ bin/checklist	2005-09-01 19:29:08 UTC (rev 1765)
@@ -4,12 +4,15 @@
 # To check for un-updated binary kernel packages, also needs grep-dctrl 
 # and a Sources file for the distribution. Set the location of the Sources
 # file in SOURCES_FILE in the environment.
+use warnings;
+use strict;
 use URI::Escape;
 use Getopt::Long;
 
 my $html=0;
 my $debug=0;
 my $suite="testing";
+my $sta = "http://secure-testing.debian.net/debian-security-updates/dists/testing/security-updates/main/source/Sources.gz";
 my $output;
 if (! GetOptions(
 		"html" => \$html,
@@ -21,8 +24,6 @@
 	die "usage: $0 [--suite suite] [--sta sta-mirror] [--html] [--output=file] [--debug] list ...\n";
 }
 
-my $sta = "http://secure-testing.debian.net/debian-security-updates/dists/testing/security-updates/main/source/Sources.gz";
-
 system("wget -q -O /tmp/Sources.sta.gz $sta");
 
 if (defined $output) {
@@ -92,6 +93,7 @@
 	
 	open (IN, $list) || die "open $list: $!";
 	while (<IN>) {
+		my $id;
 		print STDERR "line: $_" if $debug;
 		chomp;
 		if (/\s+TODO/) { # It's a todo item. Add it to the count, and ignore it
@@ -238,6 +240,8 @@
 	}
 }
 
+my %needkern;
+
 foreach my $version (sort keys %needkernel) {
 	my %images;
 	
@@ -274,7 +278,7 @@
 		}
 	}
 
-	foreach $package (sort keys %images) {
+	foreach my $package (sort keys %images) {
 		if ($images{$package} eq "0") {
 			print OUT "<li>" if ($html && $list_unknown);
 			print OUT "$package built from kernel-source-$version $needkernel{$version} needed, current version unknown\n" if $list_unknown;
@@ -293,7 +297,7 @@
 	print OUT "</ul>\n";
 	print OUT "<hr>\n";
 	print OUT "Key: ";
-	foreach $keyline (@urgencies) {
+	foreach my $keyline (@urgencies) {
 		print OUT "<span style=\"border: 1px dashed; background:".$colormap{$keyline}."\">&nbsp;$keyline&nbsp;</span> ";
 	}
 	print OUT "<br>";