[Secure-testing-commits] r16215 - bin lib/python

[Michael Gilbert]

Author: gilbert-guest
Date: 2011-02-21 04:10:00 +0000 (Mon, 21 Feb 2011)
New Revision: 16215

Modified:
   bin/tracker_service.py
   lib/python/security_db.py
Log:
show unimportant issues on the per-package pages (closes: #479727)

Modified: bin/tracker_service.py
===================================================================
--- bin/tracker_service.py	2011-02-21 04:09:38 UTC (rev 16214)
+++ bin/tracker_service.py	2011-02-21 04:10:00 UTC (rev 16215)
@@ -544,17 +544,23 @@
              
              H2('Open issues'),
              make_table(gen_bug_list(self.db.getBugsForSourcePackage
-                                     (self.db.cursor(), pkg, True)),
+                                     (self.db.cursor(), pkg, True, False)),
                         caption=('Bug', 'Description'),
                         replacement='No known open issues.'),
 
+             H2('Open unimportant issues'),
+             make_table(gen_bug_list(self.db.getBugsForSourcePackage
+                                     (self.db.cursor(), pkg, True, True)),
+                        caption=('Bug', 'Description'),
+                        replacement='No known unimportant issues.'),
+
              H2('Resolved issues'),
              make_table(gen_bug_list(self.db.getBugsForSourcePackage
-                                     (self.db.cursor(), pkg, False)),
+                                     (self.db.cursor(), pkg, False, True)),
                         caption=('Bug', 'Description'),
                         replacement='No known resolved issues.'),
              
-             H2('Security Announcements'),
+             H2('Security announcements'),
              make_table(gen_bug_list(self.db.getDSAsForSourcePackage
                                      (self.db.cursor(), pkg)),
                         caption=('DSA', 'Description'),

Modified: lib/python/security_db.py
===================================================================
--- lib/python/security_db.py	2011-02-21 04:09:38 UTC (rev 16214)
+++ lib/python/security_db.py	2011-02-21 04:10:00 UTC (rev 16215)
@@ -1665,7 +1665,7 @@
             (pkg,))
         return flag
 
-    def getBugsForSourcePackage(self, cursor, pkg, vulnerable):
+    def getBugsForSourcePackage(self, cursor, pkg, vulnerable, unimportant):
         """Returns a generator for a list of (BUG, DESCRIPTION) pairs
         which have the requested status.  Only bugs affecting supported
         releases are returned."""
@@ -1678,7 +1678,8 @@
             WHERE sp2.name = sp.name AND sp2.release = sp.release
             AND sp2.subrelease = 'security' AND sp2.archive = sp.archive
             AND st2.package = sp2.rowid AND st2.bug_name = st.bug_name
-            ORDER BY st2.vulnerable DESC), 1)) AS vulnerable
+            ORDER BY st2.vulnerable DESC), 1)) AS vulnerable,
+            st.urgency = 'unimportant' OR NOT vulnerable AS unimportant
             FROM source_packages AS sp, source_package_status AS st, bugs
             WHERE sp.name = ?
 	    AND sp.release IN ('lenny', 'squeeze', 'wheezy', 'sid')
@@ -1687,8 +1688,8 @@
             AND bugs.name = st.bug_name
             AND bugs.name NOT LIKE 'DSA-%'
             GROUP BY bugs.name, bugs.description, sp.name)
-            WHERE vulnerable = ?
-            ORDER BY name""", (pkg, vulnerable))
+            WHERE vulnerable = ? AND unimportant = ?
+            ORDER BY name""", (pkg, vulnerable, unimportant))
 
     def getDSAsForSourcePackage(self, cursor, package):
         return cursor.execute(