[Secure-testing-commits] r28965 - bin lib/python static

[Ulrike Uhlig]

Author: u-guest
Date: 2014-09-22 22:27:02 +0000 (Mon, 22 Sep 2014)
New Revision: 28965

Modified:
   bin/tracker_service.py
   lib/python/web_support.py
   static/style.css
Log:
use labels instead of spans in filter checkbox area



Modified: bin/tracker_service.py
===================================================================
--- bin/tracker_service.py	2014-09-22 22:26:14 UTC (rev 28964)
+++ bin/tracker_service.py	2014-09-22 22:27:02 UTC (rev 28965)
@@ -54,10 +54,10 @@
         l.append(INPUT(type='hidden', name='filter', value='1'))
         for (prop, desc, field) in self.action_list:
             if prop in self.filters:
-                l.append(SPAN(INPUT(desc, type='checkbox', name='filter', value=prop, checked='checked'), rel=field))
+                l.append(LABEL(INPUT(desc, type='checkbox', name='filter', value=prop, checked='checked'), rel=field))
                 self.params[prop]=1
             else:
-                l.append(SPAN(INPUT(desc, type='checkbox', name='filter', value=prop), rel=field))
+                l.append(LABEL(INPUT(desc, type='checkbox', name='filter', value=prop), rel=field))
 
         return FORM(tag("span",l, id="filters"),
                     INPUT(type='submit', value='Apply'),

Modified: lib/python/web_support.py
===================================================================
--- lib/python/web_support.py	2014-09-22 22:26:14 UTC (rev 28964)
+++ lib/python/web_support.py	2014-09-22 22:27:02 UTC (rev 28965)
@@ -419,6 +419,8 @@
     return tag('td', contents)
 def FORM(*__contents, **__attribs):
     return Tag('form', __contents, __attribs)
+def LABEL(*__contents, **__attribs):
+    return Tag('label', __contents, __attribs)
 def INPUT(*__contents, **__attribs):
     return Tag('input', __contents, __attribs)
 def UL(contents):

Modified: static/style.css
===================================================================
--- static/style.css	2014-09-22 22:26:14 UTC (rev 28964)
+++ static/style.css	2014-09-22 22:27:02 UTC (rev 28965)
@@ -137,6 +137,10 @@
 	border-bottom: 1px solid #ddd;
 }
 
+label {
+	cursor: pointer;
+}
+
 input[type="text"] {
 	background: #fff;
 	border: 1px solid #ddd;
@@ -167,30 +171,28 @@
 	vertical-align: middle;
 }
 
-span[rel="urgency"] {
+label[rel="urgency"] {
 	padding: 0.5em 0;
 	color: #fff;
 	/*background: #729fcf;*/
 	background: #ad7fa8;
 }
 
-span[rel="scope"] {
+label[rel="scope"] {
 	padding: 0.5em 0;
 	color: #fff;
 	/*background: #3465a4;*/
 	background: #75507b;
 }
 
-span[rel="extra"] {
+label[rel="extra"] {
 	padding: 0.5em 0;
 	color: #fff;
 	/*background: #204a87;*/
 	background: #5c3566;
 }
 
-span[rel="urgency"]:last-child,
-span[rel="scope"]:last-child,
-span[rel="extra"]:last-child {
+label[rel="extra"]:last-child {
 	margin-right: 0.5em;
 	padding-right: 0.5em;
 }