[Secure-testing-commits] r46533 - bin

Raphaël Hertzog hertzog at moszumanska.debian.org
Fri Nov 25 10:20:57 UTC 2016


Author: hertzog
Date: 2016-11-25 10:20:57 +0000 (Fri, 25 Nov 2016)
New Revision: 46533

Modified:
   bin/review-update-needed
Log:
Fix bin/review-update-needed

"git-blame -p" only displays meta-data the first time a commit appears.
But when a commit modifies multiple lines at different places in the
file, then we use the wrong metadata for all modified lines except the first.

With --line-porcelain, we get all the metadata for each line and it
works as expected.

Modified: bin/review-update-needed
===================================================================
--- bin/review-update-needed	2016-11-25 10:10:44 UTC (rev 46532)
+++ bin/review-update-needed	2016-11-25 10:20:57 UTC (rev 46533)
@@ -47,8 +47,8 @@
     sys.stderr.write("ERROR: works only in a git-svn checkout\n")
     sys.exit(1)
 
-process = subprocess.Popen(["git", "blame", "-p", "--", dsa_dla_needed],
-                           stdout=subprocess.PIPE)
+process = subprocess.Popen(["git", "blame", "--line-porcelain", "--",
+                            dsa_dla_needed], stdout=subprocess.PIPE)
 context = {}
 in_preamble = True
 all_entries = []




More information about the Secure-testing-commits mailing list