[Git][security-tracker-team/security-tracker][master] bin/lts-needs-forward-port: fix lib path

Sylvain Beucler beuc at beuc.net
Mon Jul 26 10:31:00 BST 2021


Hi Emilio,

On Mon, Jul 26, 2021 at 11:05:37AM +0200, Emilio Pozuelo Monfort wrote:
> On 24/07/2021 15:10, Sylvain Beucler (@beuc) wrote:
> > 64051666 by Sylvain Beucler at 2021-07-24T15:09:33+02:00
> > bin/lts-needs-forward-port: fix lib path
> > - - - - -
> > =====================================
> > bin/lts-needs-forward-port.py
> > =====================================
> > @@ -19,9 +19,9 @@ import argparse
> >   import collections
> >   import sys
> > +import setup_paths
> >   from tracker_data import TrackerData
> > -import setup_paths
> >   import config
> 
> Out of curiosity, did you have any issue that caused you to change this? I'm
> surprised this was needed as tracker_data is in bin/ and not in lib/python,
> but perhaps there was a situation where this change helped.

Indeed, here's what I get without the fix:

$ git show 64051666c68ee3e51aaa90734594cc9101f67866 | patch -p1 -R
$ bin/lts-needs-forward-port.py 
Traceback (most recent call last):
  File "bin/lts-needs-forward-port.py", line 22, in <module>
    from tracker_data import TrackerData
  File "/.../security-tracker/bin/tracker_data.py", line 23, in <module>
    from debian_support import PointUpdateParser
ModuleNotFoundError: No module named 'debian_support'

It's probably related to 8846bec763397a5dd90bb8fbde674a5ba127b560 a
few months ago (tracker_data now requiring lib/python as well).

Maybe tracker_data.py should call 'setup_paths' directly now, though
that sounds like something to call early in each CLI binary.

Cheers!
Sylvain



More information about the debian-security-tracker-commits mailing list