[xml/sgml-pkgs] Bug#315759: dead code in update-xmlcatalog

Sergio Gelato Sergio Gelato <Sergio.Gelato@astro.su.se>, 315759-maintonly@bugs.debian.org
Sat, 25 Jun 2005 18:32:40 +0200


Package: xml-core
Version: 0.09
Severity: minor

At line 313 of update-xmlcatalog, there is an
    if ( defined( $package ) && defined( $file ) )
However, the synopsis does not document the possibility of using both 
--package and --file together, and code leading up to that test explicitly
raises a fatal error if that happens. As a result, the logical 
expression at line 313 always evaluates to false.

This may be harmless but makes one wonder whether the && might not have 
been intended to be a ||. Please either correct or clarify the code, as 
appropriate.