[xml/sgml-pkgs] Bug#545147: debian/rules: wrong mktemp invocation

[Tanguy Ortolo]

Package: docbook-xml
Version: 4.5-6
Severity: important
Tags: patch
Justification: fails to build from source


Hello,

In debian/rules, the target get-orig-source uses mktemp like this:
TMPDIR=`mktemp -d docbook-xml-$(version).orig` ;

This is an incorrect use of mktemp, that leads to an error:
mktemp: too few X's in template `pouet'

Indeed, mktemp is not for making directories with a fully specified name, but
with a variable part. Here, the goal is to make a directory with a given name,
so I think it would be more appropriate to just use mkdir. Here is a patch to
do that.

Regards,

-- 
Tanguy Ortolo

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.30-1-686 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages docbook-xml depends on:
ii  sgml-base                     1.26       SGML infrastructure and SGML catal
ii  sgml-data                     2.0.3      common SGML and XML data
ii  xml-core                      0.12       XML infrastructure and XML catalog

docbook-xml recommends no packages.

Versions of packages docbook-xml suggests:
pn  docbook                    <none>        (no description available)
pn  docbook-defguide           <none>        (no description available)
pn  docbook-dsssl              <none>        (no description available)
ii  docbook-xsl                1.75.2+dfsg-1 stylesheets for processing DocBook

-- no debconf information
-------------- next part --------------
--- rules.orig	2009-09-05 12:47:17.000000000 +0200
+++ rules.mktemp	2009-09-05 12:57:46.000000000 +0200
@@ -147,7 +147,8 @@
 .PHONY: get-orig-source
 get-orig-source:
 	set -ex ; \
-	TMPDIR=`mktemp -d docbook-xml-$(version).orig` ; \
+	TMPDIR=docbook-xml-$(version).orig ; \
+	mkdir $$TMPDIR ; \
 	touch "$$TMPDIR"/ChangeLog.upstream ; \
 	for db in 4.5 4.4 4.3 4.2 ; do \
 		dbxver=`echo $${db} | sed -e 's/\.//g'` ; \