[xml/sgml-pkgs] Bug#676717: dh_installcatalogs transition and w3c-dtd-xhtml removal bugs

Osamu Aoki osamu at debian.org
Sat Jun 23 13:29:29 UTC 2012


Thanks for completing sgml-base transition.  Here is some comments on
sgml-base from an outside observer.

On Sat, Jun 23, 2012 at 12:25:22PM +0200, Helmut Grohne wrote:
> I attached a revised version (with minor changes) and got the following
> reviews:

Since you got enough impressive people, you can treat this as just FYI
and non-blocking comment.

> So unless someone speaks up, I will try to get the attached .debdiff
> uploaded.

This is non-essential but I thought it may be good idea not to make
postinst script robust.  As it is written now, any non-zero exit code of
update-catalog will break postinst script.

> diff -Nru sgml-base-1.26+nmu3/debian/sgml-base.postinst sgml-base-1.26+nmu4/debian/sgml-base.postinst
> --- sgml-base-1.26+nmu3/debian/sgml-base.postinst	2012-05-28 13:58:23.000000000 +0200
> +++ sgml-base-1.26+nmu4/debian/sgml-base.postinst	2012-06-22 17:22:31.000000000 +0200
> @@ -61,12 +61,12 @@
>      fi
>      ## ------------------------------------------------------------------
> -    update-catalog --update-super
> +    update-catalog --quiet --update-super
>      ln -sf /var/lib/sgml-base/supercatalog /etc/sgml/catalog
>  fi
>  if [ "$1" = "triggered" ]
>  then
> -    update-catalog --update-super
> +    update-catalog --quiet --update-super

Why not like:
       update-catalog --quiet --update-super ||
       echo "SGML catalog is broken. Read /usr/share/doc/sgml-base/README.trouble." 1>&2

This way, postinst will not stop and it will not be quiet when it should
not be.  It will not stop installation.  I may be wrong here.... though.

FYI: I did not understand why this script returns 
 * 1=error for normal errors, 
 * 0=non-error for goods and 
 * -1=error (for shell this 255) for --help and --version. 
The last type was not expected.


More information about the debian-xml-sgml-pkgs mailing list