[xml/sgml-pkgs] Bug#800157: docbook2x: Please re-enable autoreconfing

[Gianfranco Costamagna]

Hi again Chris
(sorry for the sparing of your time, I tried to upload in order to make you aware of the fix.

However your time might be not spared, since the fix I did is a little bit different.

-eval static_datadir="$datadir"
+eval eval static_datadir="$datadir"


instead of your
+old_val=""
+until test "$static_datadir" = "$old_val"; do
+	old_val="$static_datadir"
+	eval static_datadir="$static_datadir"
+done

do you think I should apply your patch?
(I can upload with the patch on 799755 even if it doesn't fix the issue for me)

cheers,

Gianfranco





Il Domenica 27 Settembre 2015 16:12, Chris Lamb <lamby at debian.org> ha scritto:
Package: docbook2x
Version: 0.8.8-11
Severity: wishlist
Tags: patch

Hi,

Related to #800142, please re-enable autoreconfing. Just "dropping
stuff" because it's broken doesn't seem like a good idea from a QA point
of view.

Autoreconfing is best practice as it can automatically fix a bunch of
porting and archive-wide support for stuff (eg. LFS). It also ensures a
package can be genuinely rebuilt from its sources.

Patch attached. (Note the extra change required to ./configure.ac to
prevent #800142 re-appearing.)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-