[xml/sgml-pkgs] Debian NEW review of xmlsec1 1.3.10-1: ACCEPTED

[Rene Engelhard]

Hi,

I pondered to just ignoring this but since 1.3.11 was released today and needs NEW again...

Am 08.04.26 um 07:31 schrieb awm at debian.org:
> Please consider switching the debian/copyright to DEP-5 format for
> easier processing by automated systems.
>
> Also some lintian warnings suggest the packaging in general has not
> really been reviewed here for a good while, and would be worth a
> general cleanup.

Not really.

Let's loook at https://udd.debian.org/lintian/?packages=xmlsec1: (sorting by me to reply to matching ones together)

xmlsec1    1.3.10-2 (forky sid)    libxmlsec1-10310/1.3.10-2 warning    symbols-file-contains-debian-revision    8    on symbol xmlSecHrefKWCamellia128 at Base and 2 others (libxmlsec1.so.10310) [symbols]
xmlsec1    1.3.10-2 (forky sid)    libxmlsec1-nss10310/1.3.10-2 warning    symbols-file-contains-debian-revision    8    on symbol xmlSecNssTransformConcatKdfGetKlass at Base (libxmlsec1-nss.so.10310) [symbols]
xmlsec1    1.3.10-2 (forky sid) libxmlsec1-openssl10310/1.3.10-2    warning symbols-file-contains-debian-revision    8    on symbol xmlSecOpenSSLCreateMemBio at Base and 5 others (libxmlsec1-openssl.so.10310) [symbols]

Yeah, those were from before I inherited this/moved over to XML Group. That's basically a no-op since the package name changed (and anything newer uses newer functions anyway.).

Should probably be overridden now...

xmlsec1    1.3.10-2 (forky sid)    libxmlsec1-dev/1.3.10-2 warning    executable-not-elf-or-script    8 [usr/share/doc/libxmlsec1-dev/examples/mywin32make.bat]

Example script not used for us. No need to do anything-

xmlsec1    1.3.10-2 (forky sid)        warning build-depends-on-obsolete-package    1    Build-Depends: pkg-config => pkgconf

Deliberate. pkgconf provides pkg-config. Everything works,

xmlsec1    1.3.10-2 (forky sid)        warning obsolete-debian-watch-file-standard    1    2 [debian/watch]
xmlsec1    1.3.10-2 (forky sid)        warning uses-debhelper-compat-file    1    [debian/compat]

I don't buy the argument to update just for updating. There is no difference between 2 and 4 affecting us, just exchaning version=2 to version=4 just works.

Same as debian/compat 11 to debhelper-compat (= 11)

Did that now becausee I "need" to reply to this mail anyway, but...


Regards,


Rene

> Thanks!
>
> Full review details: https://dfsg-new-queue.debian.org/reviews/xmlsec1