[Debichem-devel] gabedit - proposed patch for sprintf abuse

[Daniel Leidert]

     A. Am Mittwoch, den 31.12.2008, 18:59 -0800 schrieb Nicholas Breen:
> A recent post on debian-devel [1] highlighted a fairly common, but
> technically incorrect use of sprintf() that was causing some breakage in
> Ubuntu.  One of the packages was gabedit, and it's actually got more
> problems than the check indicated - it's using a fair number of calls
> such as:
>   sprintf(buf, "%s----", buf);
> instead of the more straightforward
>   strcat(buf, "----");
> ...for unknown reasons.
> 
> Attached is a patch that fixes all the problems either by fixing up the
> sprintf syntax or by replacement with strcat.  Probably worth sending
> upstream.

ACK.

> Daniel - want me to add it as a dpatch to the SVN repo?

Please do so.

Regards, Daniel