[Debichem-devel] Bug#616742: bug 616742

[Barry Warsaw]

On Apr 28, 2011, at 12:58 AM, Daniel Leidert wrote:

>Am Mittwoch, den 27.04.2011, 17:16 -0400 schrieb Barry Warsaw:
>
>> I've worked up a patch for bug 616742, which converts avogadro from
>> python-central to dh_python2.  I've tested this and it works for me locally.
>> Note that this does not fix the packaging to build for multiple versions of
>> Python, but seeing as Python 2.6 is currently the default for Wheezy, that
>> should be fine for now.
>>
>> Please let me know what you think.
>
>The patch has a few issues, e.g. it hardcodes the python version in
>debian/python-avogadro.install (the change here is useless - please
>leave it as it is),

Done.

>which might lead to an FTBFS in the future. Another thing that comes to my
>mind is: Why is X-Python-Version >= 2.5 when we only build for the current
>version (2.6 or newer)? This should be set in an automated way and not
>hardcoded.

AFAICT, avogadro is only able to build for one version of Python; it can't
build for both Python 2.6 and 2.7.  At least, not the way the rules file is
currently written.  As for why I picked 2.5, I thought that was avogadro's
minimum Python requirement, and dh_python2 doesn't support 'all' or 'current'
in X-Python-Version.  In practice, if you're only going to build for the
current default version of Python, you don't need this line at all, so I've
removed it.

(I don't know whether dh_python2 supports an automatic X-Python-Version, but
I'm trying to find that answer.)

>I further see some differences to `man dh_python2', but I didn't
>figure them out yet - e.g. including python-distutils.mk.

Right, you don't want to include python-distutils.mk because python-avogadro
isn't distutils-based, i.e. there is no setup.py file.

>JFTR: We should finally change to dh 7 for avogadro.

Agreed, that would be nicer, but I thought that would be inappropriate for my
patch.

I've attached an updated diff.

Cheers,
-Barry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 616742.diff
Type: text/x-patch
Size: 2223 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debichem-devel/attachments/20110429/85e38dd3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debichem-devel/attachments/20110429/85e38dd3/attachment.pgp>