[Debichem-devel] cclib_1.0.1-1_i386.changes REJECTED

[Karol M. Langner]

On Fri, Jul 29, 2011 at 12:58:45AM +0200, Michael Banck wrote:
> Hi,
> 
> On Wed, Jul 27, 2011 at 03:26:17PM +0200, Karol M. Langner wrote:
> > On Tue, Jul 26, 2011 at 06:43:18PM +0200, Michael Banck wrote:
> > > Hi,
> > > 
> > > On Tue, Jul 26, 2011 at 04:01:21PM +0200, Karol M. Langner wrote:
> > > > On Tue, Jul 26, 2011 at 02:16:15PM +0200, Michael Banck wrote:
> > > > > Once the alioth trouble is resolved, I'll upload the package.
> > > > 
> > > > Did these and other changes I think were appropriate. The debichem svn repo
> > > > now contains up-to-date files for two separate source packages, and I just
> > > > reuploaded the pckages to mentors.debian.net.
> > > 
> > > Oops, I found another issue (well, actually lintian did, apparently I
> > > forgot to run it before):
> > > 
> > > E: cclib: python-script-but-no-python-dep ./usr/bin/cclib-cda
> > > 
> > > And indeed the Depends in the package has no python:
> > > 
> > > nighthawk~/build$ dpkg -I cclib_1.0.1-1_all.deb  | grep Depends
> > >  Depends: python-cclib (= 1.0.1-1)
> > > nighthawk~/build$ dpkg -I python-cclib_1.0.1-1_all.deb  | grep Depends
> > >  Depends: python-numpy
> > > 
> > > You need to add either python-support or python-central to your
> > > Build-Depends in order to get ${python:Depends} expanded.  Which one you
> > > is up to your taste, they behave pretty similar but are different
> > > implementations.  Another python package from debichem (pymol) uses
> > > python-support, e.g.
> > 
> > OK, I managed to do this better, using dh_python2, which as I understand it
> > is now preferred over dh_pysupport.
> > 
> > I commited all changes and the packages are on mentors.debian.net.
> 
> I have uploaded cclib now, many thanks for your work!
> 
> After your last change to cclibd-data, I get the following new lintian
> warning though, so I refrained from uploading that for now:
> 
> nighthawk~/build$ lintian cclib-data_1.0.1-1_i386.changes 
> W: cclib-data: new-package-should-close-itp-bug
> W: cclib-data: empty-binary-package

Thanks for uploading... I now see cclib in unstable, very cool for me as
a long time Debian user :)

As for cclib-data... turns out our stable tarball was missing one __init__.py
so nothing was added to the deb. It should be fixed now, in the repo
and on mentors.debian.net.

Cheers,
Karol

-- 
written by Karol M. Langner
Fri Jul 29 15:56:46 CEST 2011