[Debichem-devel] [ftpmaster at ftp-master.debian.org: cinfony_1.0-1_i386.changes ACCEPTED into unstable]

[Michael Banck]

Hi Noel,

FYI, cinfony is now in Debian.

However, you might want to consider adding some more explicit copyright
information, including the years and spell out the BSD license at least
once.

I suggest adding some boilerplate at the top of each python source file
like

# Copyright (C) 2008-2011 Noel O'Boyle <baoilleach at gmail.com>
#
# This file is licensed under the BSD license, see COPYING

(and adding the BSD license to a top-level COPYING), or possibly copying
the BSD license (it is very short) in every source file, if you feel it
doesn't clutter things up too much.

I agree with Greg that BSD is fine for this with respect to OpenBabel
licensing as it is less strict than the GPL - however, it might mean
that people /using/ cinfony cannot count on just the BSD - using the
OpenBabel features probably does an implicit relicense of the code to
GPL.  This further means proprietary usage of cinfony is more limited
than the BSD usually allows.  Anyway, I am not a lawyer.

Further, you could consider adding a test target to the setup.py - took
me a bit to figure out how to run it properly.  Unfortunately, there
seem to be still some issues with CDK, so those tests fail (as does a
simply "from cinfony import cdk"), so that part is currently not working
in Debian.

This is the current description, in case you want to review and improve
it:

Description: Python abstraction layer to cheminformatics toolkits
 Cinfoy provides a common Python interface to various cheminformatics
 toolkits.  This makes it possible to use the complementary features of
 cheminformatics toolktis using a common interface.  If functionality is
 provided by more than one toolkit, the Cinfony user can choose the
 implementation they prefer.
 .
 Cinfony supports the following toolkits:
  * OpenBabel
  * RDKit
  * CDK
 .
 Cinfony also provides the Webel web services module.


Finally, what about documentation?  The stuff on the Google Code site is
pretty nice, but what's its license?  It would be great if this could be
included in a further release so it is more readily available to people
downloading the program via some distribution.


Best regards,

Michael
-------------- next part --------------
An embedded message was scrubbed...
From: Debian FTP Masters <ftpmaster at ftp-master.debian.org>
Subject: cinfony_1.0-1_i386.changes ACCEPTED into unstable
Date: Sun, 30 Oct 2011 13:17:07 +0000
Size: 2182
URL: <http://lists.alioth.debian.org/pipermail/debichem-devel/attachments/20111030/c8ba059e/attachment.mht>