[Debichem-devel] Bug#643463: qutemol: FTBFS: src/pngSave.cpp:58:15: error: format not a string literal and no format arguments [-Werror=format-security]

[Didier Raboud]

Source: qutemol
Version: 0.4.1~cvs20081111-1
Severity: serious
Tags: wheezy sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20110923 qa-ftbfs hardening-format-security hardening
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> g++ -DPKGDATADIR='"/usr/share/qutemol"' -Ivcg -Isrc -I.  -I/usr/lib/wx/include/gtk2-unicode-release-2.8 -I/usr/include/wx-2.8 -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D__WXGTK__ -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall   -c -o src/pngSave.o src/pngSave.cpp
> src/pngSave.cpp: In function 'void trace(const char*, const char*)':
> src/pngSave.cpp:58:15: error: format not a string literal and no format arguments [-Werror=format-security]
> src/pngSave.cpp:59:25: error: format not a string literal and no format arguments [-Werror=format-security]
> cc1plus: some warnings being treated as errors
> 
> make[1]: *** [src/pngSave.o] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2011/09/23/qutemol_0.4.1~cvs20081111-1_lsid64.buildlog

This happened because since dpkg 1.16.0 [0], hardening flags are enabled 
under various conditions.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.