[Debichem-devel] Chemical drawing program

[Michael Banck]

Hi Lennard,

On Wed, Oct 21, 2015 at 09:57:10AM +0200, Wasserthal wrote:
> >>It can be found at www.github.com/Wasserthal/lhendraw
> >There's been quite some activity recently which is great!
> >
> >However, there is not much documentation there. Are the screenshots from
> >http://www.nefkom.net/wasserthal/lhendraw.html still current?  How easy
> >is it to use for end-users?
> >
> >I won't have much time over the weekend but I will try to review your
> >packaging next week.
>
> Sorry to bump you, but what are the next steps?

I've now managed to take a look at the lhendraw packaging, sorry that it
took me so long, but I was busy and/or travelling and other stuff
earlier.

The following are critical issues that need to be fixed before lhendraw
can be uploaded to Debian:

* debian/copyright: That file pertains to source files, not binary
files, so "lhendraw" is not correct.  I assume all the files are under
the same license and your copyright, so you can just replace "Files:
lhendraw" with "Files: *" and be done.

* debian/control - Build-Depends: The following development libraries
are missing according to my attempts to build lhendraw: libx11-dev,
libxmu-dev and libsdl1.2-dev.

* debian/control - Depends: The required dynamic libraries should be
automatically generated during package build via dh_shlibdeps (called by
default by dh). So the Depends: line should read: "${shlibs:Depends}
${misc:Depends}" (the former for the shared libraries, the latter for
any other additional dependencies a debhelper programs might need to add
now or in the future).

* debian/control - Description: The < and > are invalid syntax I
believe, or at least unusual and might confuse/trick up external
programs/services parsing them - just remove them.

The following are non-critical issues you might want to consider fixing:

* debian/changelog: I understand that you keep the Debian packaging in
your upstream source, but nevertheless, it is best practise to assign a
Debian revision (like 0.6-1, 0.6-2 etc.) for cases where we need to
change/fix things in Debian before you get around to make a new github
release.  Renaming it to 0.6-1 would also imply having an .orig.tar.gz
file for the source package and possibly a debian.tar.gz delta.  For git
packaging, this is usually done via a separate branch "debian" which
includes the debian/ directory, whereas the master upstream branch
wouldn't.

* The manpage debian/manpage.1 is not being installed, and is just the
stub so could be removed.

* debian/control - Build-Depends: gcc/g++ are implicit as they are being
installed by the build-essential package so need not be mentioned

* debian/control - Section: Should be science

* debian/control - Priority: Should be optional


Michael