[Debichem-devel] Bug#838733: Bug#838733: experimental version of avogadro FTBFS on armel and armhf

[Michael Banck]

Hi Peter,

On Sat, Sep 24, 2016 at 03:19:53AM +0100, peter green wrote:
> package: avogadro
> version: 1.1.1-1~exp3.1
> severity: serious
> X-Debbugs-CC: pochu at debian.org, gladk at debian.org, ginggs at debian.org,
> mbanck at debian.org
> 
> While discussing possible soloutions to bug 833770 Graham Inggs sugested
> >What about uploading version 1.1.1 from experimental to unstable?
> 
> Emilio Pozuelo Monfort pointed out.
> >Note that the experimental version fails to build on armel/armhf (at least).
> 
> I decided to take a look at this.

Thank you for working on it.

The current work-around towards 1.2.0 is disabling the QTAIM extension,
but that would be a shame.

> It appears that Eigen::Vector3d produces a Matrix<double, 3, 1> but
> electronDensity expects a Matrix<qreal,3,1>
> 
> On most architectures qreal is defined as double, so this works but on arm32
> architectures qreal
>  is defined as float so it breaks
> 
> The first thing I tried was changing stuff from qreal to double to make it
> match but that led down a massive rabbit hole.
> 
> So I then took a closer look at what Eigen::Vector3d was. Turns out it's a
> typedef for Eigen::Matrix< double , 3 , 1>
> 
> So it seems the fix is simply to replace Eigen::Vector3d with Eigen::Matrix<
> qreal , 3 , 1>. I've just set off a test build with that change, will report
> results in the morning.

Let us know how it goes.

Also, there'a pull request for 1.2.0 adapting the current Eigen3 patch
which discusses some related problems.  I guess this needs some GUI
testing once it comiles...

The PR is here: https://github.com/cryos/avogadro/pull/38


Michael