[Debichem-devel] libodsstream packaging (Was: Bug#879556: ITP: beads -- 2-DE electrophoresis gel image spot detection)

[Olivier Langella]

Hi Andreas,

>   
> Are you able to build the package now that way?
Yes it works fine.
>   
>>> Just let us know here if you keep on having trouble.
>> it seems that the dh_auto_build problem is fixed. from what I understood of
>> the debian helper automatic mecanisms, overriding is not easy because one
>> must keep the same logic (creating and naming temporary directories...), but
>> it is possible to only inject cmake arguments to the configuration step or
>> inject make targets in the build step.
> 
> You can also do quilt patches.  I did so when trying to avoid that rpath
> is added.  The workflow is:
> 
>     quilt push -a  # incase there are existing patches
>     quilt new PATCHNAME
>     quilt edit FILE_TO_PATCH
>     quilt refresh
>     quilt pop -a   # redo all patching before commiting to Git!
>     git add debian/patches/PATCHNAME
>     git commit -a
> 
> If you want to change a certain patch repeat
> 
>     git push
> 
> until the patch you want to enhance is active and continue with
> 
>     git edit FILE_TO_PATCH
I am not familiar with quilt patches, but I will learn that.
> 
> It would be great if you could fix my failed attempt to implement
> 
>     https://wiki.debian.org/RpathIssue#CMake
> 
> Unfortunately I'm quite illiterate in cmake and thus failed to do it
> properly as you can see if you try to run
> 
>     lintian libodsstream_0.4.11-1_amd64.changes
> 
> which results in an error
> 
>     E: ods2tsv: binary-or-shlib-defines-rpath usr/bin/ods2tsv /build/libodsstream-0.4.11/obj-x86_64-linux-gnu/src
> 
> This needs to be fixed.
I think it's ok now. I've added this argument to the configure step :
  -DCMAKE_SKIP_RPATH=1
and there is no more rpath in the binary file.
> 
>> I've also seen that the man page I've left in the package was the QuaZip
>> one. I left it here in order to make my own but I forgot it. It's fixed now,
>> but I guess I am yet far from the debian quality requirements.
> 
> I did some polishing cleaning up several lintian issues.  Please
> also enhance the long description of the ods2tsv package and
> check d/copyright for the proper starting year.

OK, I'll do that as soon as possible.

to avoid an other lintian error :
E: ods2tsv: arch-dependent-file-not-in-arch-specific-directory 
usr/bin/ods2tsv

I've changed the debian control multi arch for that package to "no".
There are only warnings left now.

>   
>>> Feel free to keep Qt4 in your upstream source - but I think we should
>>> leave it out in the Debian packaging.
>>
>> Ok, we can leave it in debian packaging, no problem.
> 
> I have removed this one in my cleanup.
ok
> 
> Please let me know if you was able to solve the rpath issue and I'll
> check again.

it's done, and I will fix description and manpage issues.
I'm also working on these warnings "package-name-doesnt-match-sonames" 
and "non-dev-pkg-with-shlib-symlink".
I think I have a solution for the symlinks, but perhaps that the one on 
the soname will require a package rename.


Kind regards
Olivier


-- 
Olivier Langella
http://pappso.inra.fr/bioinfo
Génétique Quantitative et Évolution - Le Moulon
INRA - Université Paris-Sud - CNRS - AgroParisTech
Ferme du Moulon
91190 Gif-sur-Yvette, France
Tel : 01.69.33.23.68  Fax : 01.69.33.23.40
JID : olivier.langella at u-psud.fr