[Debichem-devel] Bug#883940: gabedit FTCBFS: uses build architecture build tools

[Helmut Grohne]

Source: gabedit
Version: 2.4.8-3
Tags: patch
User: helmutg at debian.org
Usertags: rebootstrap

gabedit fails to cross build from source, because it uses build
architecture build tools. The build architecture pkg-config fails to
find host architecture libraries. The CC assignment with ?= is
ineffective, because CC has a default. Thus The build passes the build
architecture compiler CC=cc to make overriding the cross compiler
assignment from dh_auto_build. Using host tools and letting debhelper do
its job fixes the cross build. Please consider applying the attached
patch.

Helmut
-------------- next part --------------
diff --minimal -Nru gabedit-2.4.8/debian/changelog gabedit-2.4.8/debian/changelog
--- gabedit-2.4.8/debian/changelog	2016-10-05 08:18:22.000000000 +0200
+++ gabedit-2.4.8/debian/changelog	2017-12-09 18:52:44.000000000 +0100
@@ -1,3 +1,12 @@
+gabedit (2.4.8-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Do not force the build architecture compiler "cc".
+    + Use the host architecture pkg-config.
+
+ -- Helmut Grohne <helmut at subdivi.de>  Sat, 09 Dec 2017 18:52:44 +0100
+
 gabedit (2.4.8-3) unstable; urgency=medium
 
   * debian/patches/detect_dummies_molpro.patch: New patch, fixes detection of
diff --minimal -Nru gabedit-2.4.8/debian/rules gabedit-2.4.8/debian/rules
--- gabedit-2.4.8/debian/rules	2016-02-07 18:19:50.000000000 +0100
+++ gabedit-2.4.8/debian/rules	2017-12-09 18:52:42.000000000 +0100
@@ -6,11 +6,13 @@
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
 
+-include /usr/share/dpkg/buildtools.mk
 PACKAGE=gabedit
 INSTALL=/usr/bin/install
 
-GTKLIB        = `pkg-config --libs gtk+-2.0 gtkglext-1.0 pangox`
-GTKCFLAGS     = `pkg-config --cflags gtk+-2.0 gtkglext-1.0 pangox`
+PKG_CONFIG   ?= pkg-config
+GTKLIB        = `$(PKG_CONFIG) --libs gtk+-2.0 gtkglext-1.0 pangox`
+GTKCFLAGS     = `$(PKG_CONFIG) --cflags gtk+-2.0 gtkglext-1.0 pangox`
 OGLLIB        = -lGL -lGLU
 OGLCFLAGS     = -I/usr/include
 LIBPTHREAD    = -lpthread
@@ -18,7 +20,6 @@
 OMPCFLAGS     = -DENABLE_OMP -fopenmp
 DRAWGEOMGL    = -DDRAWGEOMGL
 
-CC           ?= gcc -g
 COMMONCFLAGS ?= $(shell dpkg-buildflags --get CFLAGS)
 COMMONCFLAGS += $(shell dpkg-buildflags --get CPPFLAGS)
 COMMONCFLAGS += -DENABLE_DEPRECATED
@@ -40,8 +41,7 @@
 		OMPCFLAGS="$(OMPCFLAGS)" \
 		DRAWGEOMGL="$(DRAWGEOMGL)" \
 		COMMONCFLAGS="$(COMMONCFLAGS) $(OMPCFLAGS) $(DRAWGEOMGL)" \
-		LDFLAGS="$(LDFLAGS)" \
-		CC="$(CC)"
+		LDFLAGS="$(LDFLAGS)"
 
 override_dh_install:
 	dh_install