[Debichem-devel] Bug#856350: qutemol: FTBFS (#error This file requires compiler and library support)

[Adrian Bunk]

Control: clone -1 -2
Control: reassign -2 wx3.0-headers 3.0.2+dfsg-2
Control: retitle -2 wx3.0-headers shouldn't require C+11 in stretch
Control: affects -2 src:qutemol
Control: tags -2 patch
Control: retitle -1 qutemol must be made C++11 compatible
Control: severity -1 important

On Tue, Feb 28, 2017 at 11:23:28AM +0000, Santiago Vila wrote:
> Package: src:qutemol
> Version: 0.4.1~cvs20081111-6
>...
> g++ -DPKGDATADIR='"/usr/share/qutemol"' -Ivcg -Isrc -I. -I/usr/lib/x86_64-linux-gnu/wx/include/gtk2-unicode-3.0 -I/usr/include/wx-3.0 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -DNDEBUG -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu++98 -Wdate-time -D_FORTIFY_SOURCE=2  -c -o src/MyTab.o src/MyTab.cpp
> In file included from /usr/include/c++/6/type_traits:35:0,
>                  from /usr/include/wx-3.0/wx/strvararg.h:25,
>                  from /usr/include/wx-3.0/wx/string.h:46,
>                  from /usr/include/wx-3.0/wx/memory.h:15,
>                  from /usr/include/wx-3.0/wx/object.h:19,
>                  from /usr/include/wx-3.0/wx/wx.h:15,
>                  from src/MyTab.cpp:2:
> /usr/include/c++/6/bits/c++0x_warning.h:32:2: error: #error This file requires compiler and library support for the ISO C++ 2011 standard. This support must be enabled with the -std=c++11 or -std=gnu++11 compiler options.
>  #error This file requires compiler and library support \
>   ^~~~~
>...

This is caused by the recent binNMU (sic) of wxwidgets3.0,
that resulted in wx3.0-headers requiring a C++11 compiler
(first rebuild with gcc 6 that defaults to C++11).

This breaks building of qutemol (and potentially other rdeps) that are 
building with -std=gnu++98 to avoid C++11 FTBFS.

This should really be fixed in rdeps like qutemol, but since we
are already inside the freeze I'd suggest the following change to 
wxwidgets3.0 for stretch:

--- debian/rules.old	2017-02-28 16:23:38.000000000 +0000
+++ debian/rules	2017-02-28 16:24:09.000000000 +0000
@@ -69,7 +69,7 @@
     --with-flavour=$(DEBIAN_WXFLAVOUR) \
     --with-zlib=sys \
     --with-expat=sys \
-    $(shell DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed dpkg-buildflags --export=configure)
+    $(shell DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed DEB_CXXFLAGS_MAINT_APPEND=-std=gnu++98 dpkg-buildflags --export=configure)
 
 ifneq (,$(filter noopt,$(DEB_BUILD_OPTIONS)))
 COMMON_CONFIGURE_OPTIONS += --disable-optimise


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed