[Debichem-devel] Bug#882638: gpaw: Incorrectly creates logging files called "-" instead of logging to stdout

[Chris Lamb]

Source: gpaw
Version: 1.3.0-1
Severity: minor
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that gpaw could not be built reproducibly.

This was caused by gpaw incorrectly creating logging files called
"-" instead of logging to stdout.

Patch attached that simply removes the "open" call - the convert_string_to_fd
method in python-ase will do the right thing and open the file if
necessary.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/fix_stdout_output.patch	1970-01-01 09:00:00.000000000 +0900
--- b/debian/patches/fix_stdout_output.patch	2017-11-25 11:28:29.927047735 +0900
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2017-11-25
+
+--- gpaw-1.3.0.orig/gpaw/response/integrators.py
++++ gpaw-1.3.0/gpaw/response/integrators.py
+@@ -45,8 +45,6 @@ class Integrator():
+ 
+         if comm.rank != 0:
+             txt = devnull
+-        elif isinstance(txt, str):
+-            txt = open(txt, 'w')
+         self.fd = convert_string_to_fd(txt, comm)
+ 
+         self.timer = timer or Timer()
--- a/debian/patches/series	1970-01-01 09:00:00.000000000 +0900
--- b/debian/patches/series	2017-11-25 11:28:28.863030123 +0900
@@ -0,0 +1 @@
+fix_stdout_output.patch