[Debichem-devel] Bug#896451: shelxle FTBFS due to round() macro

[Adrian Bunk]

Source: shelxle
Version: 1.0.888-1
Severity: serious

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/shelxle.html

...
g++ -c -pipe -fopenmp -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -W -D_REENTRANT -fPIC -DQT_NO_DEBUG -DQT_OPENGL_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I. -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtOpenGL -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -I. -isystem /usr/include/libdrm -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -o fourxle.o fourxle.cpp
In file included from fourxle.h:28:0,
                 from fourxle.cpp:19:
/usr/include/c++/7/bits/random.tcc: In member function 'void std::poisson_distribution<_IntType>::param_type::_M_initialize()':
molecule.h:26:18: error: expected unqualified-id before '(' token
 #define round(x) (x<0?ceil((x)-0.5):floor((x)+0.5))
                  ^
/usr/include/c++/7/bits/random.tcc: In member function 'void std::binomial_distribution<_IntType>::param_type::_M_initialize()':
molecule.h:26:18: error: expected unqualified-id before '(' token
 #define round(x) (x<0?ceil((x)-0.5):floor((x)+0.5))
                  ^
molecule.h:26:18: error: expected unqualified-id before '(' token
 #define round(x) (x<0?ceil((x)-0.5):floor((x)+0.5))
                  ^
fourxle.cpp: In member function 'bool FourXle::loadFouAndPerform(const char*, bool)':
fourxle.cpp:119:10: warning: ignoring return value of 'char* fgets(char*, int, FILE*)', declared with attribute warn_unused_result [-Wunused-result]
     fgets(line,120,f);
     ~~~~~^~~~~~~~~~~~
fourxle.cpp:134:10: warning: ignoring return value of 'char* fgets(char*, int, FILE*)', declared with attribute warn_unused_result [-Wunused-result]
     fgets(line,120,f);
     ~~~~~^~~~~~~~~~~~
make[1]: *** [Makefile:808: fourxle.o] Error 1



molecule.h wrongly assumes that round() is always a maro in math.h.