[Debichem-devel] Bug#891750: comet-ms: please add libraries to LIBS and not to CXXFLAGS

[Gianfranco Costamagna]

Package: comet-ms
Version: 2017012-1
Severity: normal
tags: patch


Dear maintainer,

Your Makefile has a little typo, that prevents the package from linking correctly when wl-asneeded flag is used (because libraries are stripped, since the 
.o file are at the bottom of the link line)

please accept this patch, to solve the issue

--- comet-ms-2017012/debian/Makefile    2017-12-03 21:15:46.000000000 +0100
+++ comet-ms-2017012/debian/Makefile    2018-02-28 15:02:03.000000000 +0100
@@ -1,8 +1,9 @@
 CXX = g++
 GCC = gcc

-CXXFLAGS = -g -O3 -Wall -Wextra -Wno-char-subscripts -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D__LINUX__ -I/usr/include/libmstoolkit -lpthread -lmstoolkitlite
+CXXFLAGS = -g -O3 -Wall -Wextra -Wno-char-subscripts -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D__LINUX__ -I/usr/include/libmstoolkit
 EXECNAME = comet-ms
+LIBS = -lmstoolkitlite -lpthread

 COMETSEARCH = Comet.o Threading.o CometInterfaces.o CometSearch.o CometPreprocess.o CometPostAnalysis.o CometMassSpecUtils.o CometWriteOut.o CometWriteSqt.o CometWritePepXML.o CometWritePercolator.o CometWriteTxt.o CometSearchManager.o


you can also grab the patch from here:
http://launchpadlibrarian.net/358943993/comet-ms_2017012-1_2017012-1ubuntu1.diff.gz

thanks

Gianfranco

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/debichem-devel/attachments/20180228/61193580/attachment.sig>