[Debichem-devel] Processed: Re: Bug#891750: fixed in comet-ms 2017014-1

[Filippo Rusconi]

Greetings Gianfranco,

thank you for caring about libmstoolkit/comet-ms. 

On Thu, Mar 01, 2018 at 10:09:04PM +0000, Debian Bug Tracking System wrote:
>> reopen -1
>Bug #891750 {Done: Filippo Rusconi <lopippo at debian.org>} [comet-ms] comet-ms: please add libraries to LIBS and not to CXXFLAGS
>'reopen' may be inappropriate when a bug has been closed with a version;
>all fixed versions will be cleared, and you may need to re-add them.
>Bug reopened
>No longer marked as fixed in versions comet-ms/2017014-1.
>> notfixed -1 2017014-1
>Bug #891750 [comet-ms] comet-ms: please add libraries to LIBS and not to CXXFLAGS
>Ignoring request to alter fixed versions of bug #891750 to the same values previously set

I have now understood what was going on... inconsistency between build
processes, as you pointed rightly in your last message. 

Now the linker command line is 

g++ -g -O2
-fdebug-prefix-map=/home/rusconi/devel/packaging/comet-ms/development=.
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
-D_FORTIFY_SOURCE=2 -O3 -Wall -Wextra -Wno-char-subscripts -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -D__LINUX__ -I/usr/include/libmstoolkit -ICometSearch
CometSearch/CometInterfaces.o CometSearch/CometMassSpecUtils.o
CometSearch/CometSearch.o CometSearch/CometWritePepXML.o
CometSearch/CometWriteTxt.o CometSearch/CometPostAnalysis.o
CometSearch/CometSearchManager.o CometSearch/CometWritePercolator.o
CometSearch/Threading.o CometSearch/CometPreprocess.o
CometSearch/CometWriteOut.o CometSearch/CometWriteSqt.o Comet.o -L/usr/lib
-lmstoolkitlite -lm -lpthread -o comet-ms 

which looks like it should be fine.

The package installs fine on a clean sid environment.

I do not dare closing the bug yet!

Cheers,
Filippo

-- 
⢀⣴⠾⠻⢶⣦⠀  Filippo Rusconi, PhD
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  http://msxpertsuite.org
⠈⠳⣄⠀⠀⠀⠀  http://www.debian.org