[Debichem-devel] Processed: Re: Bug#891750: fixed in comet-ms 2017014-1

[Filippo Rusconi]

Ciao!

On Fri, Mar 02, 2018 at 01:39:46PM +0000, Gianfranco Costamagna wrote:
>
>>I have now understood what was going on... inconsistency between build
>>processes, as you pointed rightly in your last message.
>>
>>Now the linker command line is
>>
>>g++ -g -O2
>>-fdebug-prefix-map=/home/rusconi/devel/packaging/comet-ms/development=.
>>-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
>>-D_FORTIFY_SOURCE=2 -O3 -Wall -Wextra -Wno-char-subscripts -D_LARGEFILE_SOURCE
>>-D_FILE_OFFSET_BITS=64 -D__LINUX__ -I/usr/include/libmstoolkit -ICometSearch
>>CometSearch/CometInterfaces.o CometSearch/CometMassSpecUtils.o
>>CometSearch/CometSearch.o CometSearch/CometWritePepXML.o
>>CometSearch/CometWriteTxt.o CometSearch/CometPostAnalysis.o
>>CometSearch/CometSearchManager.o CometSearch/CometWritePercolator.o
>>CometSearch/Threading.o CometSearch/CometPreprocess.o
>>CometSearch/CometWriteOut.o CometSearch/CometWriteSqt.o Comet.o -L/usr/lib
>>-lmstoolkitlite -lm -lpthread -o comet-ms
>
>
>Sorry but build log differs from your version
>g++ -g -O3 -Wall -Wextra -Wno-char-subscripts -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D__LINUX__ -I/usr/include/libmstoolkit -lpthread -lmstoolkitlite Comet.o Threading.o CometInterfaces.o CometSearch.o CometPreprocess.o CometPostAnalysis.o CometMassSpecUtils.o CometWriteOut.o CometWriteSqt.o CometWritePepXML.o CometWritePercolator.o CometWriteTxt.o CometSearchManager.o   -o comet-ms
>
>https://buildd.debian.org/status/fetch.php?pkg=comet-ms&arch=arm64&ver=2017014-1&stamp=1519907938&raw=0
>

Very odd, indeed, I erased by base.cow directory, run cowbuilder --create and
then run gbp buildpackage on that clean environment and the linker command line
is again:

g++ -g -O2 -fdebug-prefix-map=/build/comet-ms-2017014=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -Wall -Wextra -Wno-char-subscripts -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D__LINUX__ -I/usr/include/libmstoolkit -ICometSearch CometSearch/CometInterfaces.o CometSearch/CometMassSpecUtils.o CometSearch/CometSearch.o CometSearch/CometWritePepXML.o CometSearch/CometWriteTxt.o CometSearch/CometPostAnalysis.o CometSearch/CometSearchManager.o CometSearch/CometWritePercolator.o CometSearch/Threading.o CometSearch/CometPreprocess.o CometSearch/CometWriteOut.o CometSearch/CometWriteSqt.o Comet.o -L/usr/lib -lmstoolkitlite -lm -lpthread -o comet-ms

I also tried a sbuild-based build, with the same effect:

g++ -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -Wall -Wextra -Wno-char-subscripts -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D__LINUX__ -I/usr/include/libmstoolkit -ICometSearch CometSearch/CometInterfaces.o CometSearch/CometMassSpecUtils.o CometSearch/CometSearch.o CometSearch/CometWritePepXML.o CometSearch/CometWriteTxt.o CometSearch/CometPostAnalysis.o CometSearch/CometSearchManager.o CometSearch/CometWritePercolator.o CometSearch/Threading.o CometSearch/CometPreprocess.o CometSearch/CometWriteOut.o CometSearch/CometWriteSqt.o Comet.o -L/usr/lib -lmstoolkitlite -lm -lpthread -o comet-ms

>Please use a clean environment.
>You patched Makefile, but the *debian* build system is using a special made "debian/Makefile" that is copied in the build directory before the build starts.

So, I must admit, there is something that I do not understand. Where is that special made "debian/Makefile" documented? 

>See the failure:
>https://launchpad.net/ubuntu/+source/comet-ms/2017014-1/+build/14412235
>
>and the fix:
>http://launchpadlibrarian.net/359198028/comet-ms_2017014-1_2017014-1ubuntu1.diff.gz

I wonder if you are looking at the right version that I uploaded only tens of
minutes ago:

Uploading to ftp-master (via ftp to ftp.upload.debian.org):
  Uploading comet-ms_2017014-2.dsc: done.
	  Uploading comet-ms_2017014-2.debian.tar.xz: done.
		  Uploading comet-ms-dbgsym_2017014-2_amd64.deb: done.
			  Uploading comet-ms_2017014-2_amd64.buildinfo: done.
				  Uploading comet-ms_2017014-2_amd64.deb: done.
					  Uploading comet-ms_2017014-2_amd64.changes: done.
						

It seems to me that you are looking at version 2017014-1.
Can you confirm this, please?

Ciao!

Filippo

-- 
⢀⣴⠾⠻⢶⣦⠀  Filippo Rusconi, PhD
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  http://msxpertsuite.org
⠈⠳⣄⠀⠀⠀⠀  http://www.debian.org