[Debichem-devel] Bug#957084: chemtool: ftbfs with GCC-10

[Matthias Klose]

Package: src:chemtool
Version: 1.6.14-5
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/chemtool_1.6.14-5_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
main.c: In function ‘file_ok_sel’:
main.c:3027:35: note: length computed here
 3027 |       strncpy (datadir, filename, strlen (filename) - strlen (tempstr) + 1);
      |                                   ^~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-2.0/gtk/gtktoolitem.h:31,
                 from /usr/include/gtk-2.0/gtk/gtktoolbutton.h:30,
                 from /usr/include/gtk-2.0/gtk/gtkmenutoolbutton.h:30,
                 from /usr/include/gtk-2.0/gtk/gtk.h:126,
                 from ct1.h:9,
                 from inout.c:6:
/usr/include/gtk-2.0/gtk/gtktooltips.h:73:3: warning: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead [-Wdeprecated-declarations]
   73 |   GTimeVal last_popdown;
      |   ^~~~~~~~
In file included from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from /usr/include/glib-2.0/gobject/gbinding.h:28,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
                 from /usr/include/gtk-2.0/gdk/gdk.h:32,
                 from /usr/include/gtk-2.0/gtk/gtk.h:32,
                 from ct1.h:9,
                 from inout.c:6:
/usr/include/glib-2.0/glib/gtypes.h:551:8: note: declared here
  551 | struct _GTimeVal
      |        ^~~~~~~~~
inout.c: In function ‘import_pdb’:
inout.c:732:13: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  732 |       (void)fgets (line, (int)sizeof (line), fp);
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
inout.c: In function ‘check_babel’:
inout.c:6054:13: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 6054 |       (void)fgets (data, 80, xfile);
      |             ^~~~~~~~~~~~~~~~~~~~~~~
inout.c: In function ‘check_fig2sxd’:
inout.c:6133:3: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 6133 |   fscanf (xfile, "%s", myname);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
gcc  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,--as-needed   -o src-cht/cht cht.o -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype   -lX11 -lm 
gcc  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,--as-needed   -o chemtool main.o draw.o graph.o chemproc.o undo.o inout.o -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype   -lX11 -lm 
/usr/bin/ld: graph.o:./ct1.h:281: multiple definition of `babelout'; draw.o:./ct1.h:281: first defined here
/usr/bin/ld: graph.o:./ct1.h:280: multiple definition of `outmode'; draw.o:./ct1.h:280: first defined here
/usr/bin/ld: graph.o:./ct1.h:279: multiple definition of `outtype'; draw.o:./ct1.h:279: first defined here
/usr/bin/ld: graph.o:./ct1.h:278: multiple definition of `babelin'; draw.o:./ct1.h:278: first defined here
/usr/bin/ld: graph.o:./ct1.h:277: multiple definition of `inmode'; draw.o:./ct1.h:277: first defined here
/usr/bin/ld: graph.o:./ct1.h:276: multiple definition of `intype'; draw.o:./ct1.h:276: first defined here
/usr/bin/ld: chemproc.o:./ct1.h:281: multiple definition of `babelout'; draw.o:./ct1.h:281: first defined here
/usr/bin/ld: chemproc.o:./ct1.h:280: multiple definition of `outmode'; draw.o:./ct1.h:280: first defined here
/usr/bin/ld: chemproc.o:./ct1.h:279: multiple definition of `outtype'; draw.o:./ct1.h:279: first defined here
/usr/bin/ld: chemproc.o:./ct1.h:278: multiple definition of `babelin'; draw.o:./ct1.h:278: first defined here
/usr/bin/ld: chemproc.o:./ct1.h:277: multiple definition of `inmode'; draw.o:./ct1.h:277: first defined here
/usr/bin/ld: chemproc.o:./ct1.h:276: multiple definition of `intype'; draw.o:./ct1.h:276: first defined here
/usr/bin/ld: inout.o:./ct1.h:278: multiple definition of `babelin'; draw.o:./ct1.h:278: first defined here
/usr/bin/ld: inout.o:./ct1.h:281: multiple definition of `babelout'; draw.o:./ct1.h:281: first defined here
/usr/bin/ld: inout.o:./ct1.h:277: multiple definition of `inmode'; draw.o:./ct1.h:277: first defined here
/usr/bin/ld: inout.o:./ct1.h:276: multiple definition of `intype'; draw.o:./ct1.h:276: first defined here
/usr/bin/ld: inout.o:./ct1.h:280: multiple definition of `outmode'; draw.o:./ct1.h:280: first defined here
/usr/bin/ld: inout.o:./ct1.h:279: multiple definition of `outtype'; draw.o:./ct1.h:279: first defined here
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:532: chemtool] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: *** [Makefile:609: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:433: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make: *** [debian/rules:13: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2