[Debichem-devel] Bug#964656: rdkit: FTBFS: elog.h:224:34: error: format not a string literal and no format arguments [-Werror=format-security]

[Lucas Nussbaum]

Source: rdkit
Version: 202003.4-1
Severity: serious
Justification: FTBFS on amd64
Tags: bullseye sid ftbfs
Usertags: ftbfs-20200709 ftbfs-bullseye

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

Relevant part (hopefully):
> g++ -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-unused-function -I/usr/local/include -I/<<PKGBUILDDIR>>/Code -DRDKITVER='"007300"' -I/usr/local/include -I/<<PKGBUILDDIR>>/Code -DRDKITVER='"007300"'   -I. -I/<<PKGBUILDDIR>>/Code/PgSQL/rdkit -I/usr/include/postgresql/12/server -I/usr/include/postgresql/internal  -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/mit-krb5 -fPIC -c -o adapter.o /<<PKGBUILDDIR>>/Code/PgSQL/rdkit/adapter.cpp
> In file included from /usr/include/postgresql/12/server/postgres.h:47,
>                  from /<<PKGBUILDDIR>>/Code/PgSQL/rdkit/rdkit.h:40,
>                  from /<<PKGBUILDDIR>>/Code/PgSQL/rdkit/adapter.cpp:74:
> /<<PKGBUILDDIR>>/Code/PgSQL/rdkit/adapter.cpp: In function ‘void* MolAdjustQueryProperties(CROMol, const char*)’:
> /usr/include/postgresql/12/server/utils/elog.h:224:34: error: format not a string literal and no format arguments [-Werror=format-security]
>   224 |   elog_finish(elevel, __VA_ARGS__); \
>       |                                  ^
> /<<PKGBUILDDIR>>/Code/PgSQL/rdkit/adapter.cpp:649:7: note: in expansion of macro ‘elog’
>   649 |       elog(ERROR, e.message());
>       |       ^~~~
> cc1plus: some warnings being treated as errors
> make[2]: *** [/<<PKGBUILDDIR>>/Code/PgSQL/rdkit/Makefile:112: adapter.o] Error 1

The full build log is available from:
   http://qa-logs.debian.net/2020/07/09/rdkit_202003.4-1_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.