[Debichem-devel] mdanalysis_1.0.0+dfsg1-1_amd64.changes REJECTED

[Drew Parsons]

On 2020-11-04 01:15, Sean Whitton wrote:
> Hello,
> 
> On Tue 03 Nov 2020 at 08:51PM +08, Drew Parsons wrote:
> 
>> On 2020-11-01 07:00, Sean Whitton wrote:
>>> 
>>> Looks like maintainer/install_hole.sh could go into contrib but not
>>> main.  If
>>> it's not needed for the Debian package then best to just remove.
>> 
>> 
>> Hi Sean, the maintainer subdir is just scripts upstream uses to make 
>> its
>> own packages, e.g. conda packages.  We're not using it at all.
>> 
>> HOLE is optional functionality, accessible through
>> package/MDAnalysis/analysis (analysis/hole2 in particular), only
>> activated if the hole executable happens to be available.
>> It's not core functionality. The remainder of MDAnalysis runs normally
>> (free). I don't think we gain so much by separating out the hole
>> components.  What do you think?
> 
> I'm afraid that isn't relevant.  We can't include code in main which 
> has
> non-free dependencies, whether or not it gets installed in the binary
> package.


But it's not a dependency. As far as our package is concerned, there is 
no HOLE.

It's the same situation as a header file for a library which has 
conditional GPU support for nvidia's cuda.  If cuda is not present, the 
cuda code is not compiled.

Drew