[Debichem-devel] Bug#984316: qutemol: ftbfs with GCC-11

[Matthias Klose]

Package: src:qutemol
Version: 0.4.1~cvs20081111-13
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/qutemol_0.4.1~cvs20081111-13_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
  115 |      unsigned char subblock[3];
      |                    ^~~~~~~~
g++ -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -DPKGDATADIR='"/usr/share/qutemol/"' -Ivcg -Isrc -I. `wx-config --cppflags` -DNDEBUG -Wdate-time -D_FORTIFY_SOURCE=2  -c -o src/pngSave.o src/pngSave.cpp
src/pngSave.cpp:25:6: error: variable or field ‘downsample2x2’ declared void
   25 | void downsample2x2(byte * data, int sx, int sy){
      |      ^~~~~~~~~~~~~
src/pngSave.cpp:25:20: error: reference to ‘byte’ is ambiguous
   25 | void downsample2x2(byte * data, int sx, int sy){
      |                    ^~~~
In file included from /usr/include/c++/11/cmath:42,
                 from /usr/include/c++/11/math.h:36,
                 from src/pngSave.cpp:12:
/usr/include/c++/11/bits/cpp_type_traits.h:404:30: note: candidates are: ‘enum class std::byte’
  404 |   enum class byte : unsigned char;
      |                              ^~~~
src/pngSave.cpp:22:23: note:                 ‘typedef unsigned char byte’
   22 | typedef unsigned char byte;
      |                       ^~~~
src/pngSave.cpp:25:33: error: expected primary-expression before ‘int’
   25 | void downsample2x2(byte * data, int sx, int sy){
      |                                 ^~~
src/pngSave.cpp:25:41: error: expected primary-expression before ‘int’
   25 | void downsample2x2(byte * data, int sx, int sy){
      |                                         ^~~
src/pngSave.cpp:40:6: error: variable or field ‘downsample2x2NoAlpha’ declared void
   40 | void downsample2x2NoAlpha(byte * data, int sx, int sy){
      |      ^~~~~~~~~~~~~~~~~~~~
src/pngSave.cpp:40:27: error: reference to ‘byte’ is ambiguous
   40 | void downsample2x2NoAlpha(byte * data, int sx, int sy){
      |                           ^~~~
In file included from /usr/include/c++/11/cmath:42,
                 from /usr/include/c++/11/math.h:36,
                 from src/pngSave.cpp:12:
/usr/include/c++/11/bits/cpp_type_traits.h:404:30: note: candidates are: ‘enum class std::byte’
  404 |   enum class byte : unsigned char;
      |                              ^~~~
src/pngSave.cpp:22:23: note:                 ‘typedef unsigned char byte’
   22 | typedef unsigned char byte;
      |                       ^~~~
src/pngSave.cpp:40:40: error: expected primary-expression before ‘int’
   40 | void downsample2x2NoAlpha(byte * data, int sx, int sy){
      |                                        ^~~
src/pngSave.cpp:40:48: error: expected primary-expression before ‘int’
   40 | void downsample2x2NoAlpha(byte * data, int sx, int sy){
      |                                                ^~~
src/pngSave.cpp:71:53: error: reference to ‘byte’ is ambiguous
   71 | bool PNGSaveWithAlpha( const char * filename, const byte * const data, int sx, int sy, int reverse ){
      |                                                     ^~~~
In file included from /usr/include/c++/11/cmath:42,
                 from /usr/include/c++/11/math.h:36,
                 from src/pngSave.cpp:12:
/usr/include/c++/11/bits/cpp_type_traits.h:404:30: note: candidates are: ‘enum class std::byte’
  404 |   enum class byte : unsigned char;
      |                              ^~~~
src/pngSave.cpp:22:23: note:                 ‘typedef unsigned char byte’
   22 | typedef unsigned char byte;
      |                       ^~~~
src/pngSave.cpp: In function ‘bool PNGSaveWithAlpha(const char*, const int*, int, int, int)’:
src/pngSave.cpp:127:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  127 |     if (sy>200) StartProgress("Saving PNG", sy);
      |     ^~
src/pngSave.cpp:128:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  128 |                 for(int r = sy -1; r >= 0; r--) {
      |                 ^~~
make[1]: *** [<builtin>: src/pngSave.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2