[Debichem-devel] Bug#1006980: gemmi: please use packaged doctest.h header

[Gianfranco Costamagna]

Source: gemmi
Version: 0.5.2+ds-1
Severity: important
tags: patch

Hello
the following patch

--- gemmi-0.5.2+ds.orig/tests/cif.cpp
+++ gemmi-0.5.2+ds/tests/cif.cpp
@@ -1,5 +1,5 @@

-#include "doctest.h"
+#include <doctest/doctest.h>

  #include <algorithm>
  #include <gemmi/cif.hpp>
--- gemmi-0.5.2+ds.orig/tests/main.cpp
+++ gemmi-0.5.2+ds/tests/main.cpp
@@ -1,6 +1,6 @@

  #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
-#include "doctest.h"
+#include <doctest/doctest.h>

  #include <cstdlib>  // for rand
  #include <climits>  // for INT_MIN, INT_MAX


and doing

echo third_party/doctest.h > debian/clean

and adding doctest-dev to build-dependencies helps in using the system-provided doctest version.
Note: there is a bug in doctest with newer glibc, leading to a FTBFS

The upstream doctest fix is at
https://github.com/doctest/doctest/commit/8ee91f37ba27397ef5eeedd2e542a4aaaa33ddc1
but this embedded version is too old.

So, in any case, to avoid a FTBFS bug soon, better probably use the system one.

Gianfranco