[Debichem-devel] Bug#1097484: nwchem: ftbfs with GCC-15

[Matthias Klose]

Package: src:nwchem
Version: 7.2.3-7
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/nwchem_7.2.3-7_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
echo /build/reproducible-path/nwchem-7.2.3/build-openmpi/lib/LINUX64/libnwcutil.a
/build/reproducible-path/nwchem-7.2.3/build-openmpi/lib/LINUX64/libnwcutil.a
make[4]: Leaving directory '/build/reproducible-path/nwchem-7.2.3/build-openmpi/src/pstat'
make[3]: Leaving directory '/build/reproducible-path/nwchem-7.2.3/build-openmpi/src/pstat'
Making libraries in rtdb
make[3]: Entering directory '/build/reproducible-path/nwchem-7.2.3/build-openmpi/src/rtdb'
Making all in hdbm
make[4]: Entering directory '/build/reproducible-path/nwchem-7.2.3/build-openmpi/src/rtdb/hdbm'
make[4]: Entering directory '/build/reproducible-path/nwchem-7.2.3/build-openmpi/src/rtdb'
Compiling rtdb_f2c.c...
Compiling rtdb.c...
make[5]: Entering directory '/build/reproducible-path/nwchem-7.2.3/build-openmpi/src/rtdb/hdbm'
Compiling context.c...
Compiling rtdb_seq.c...
Compiling context_f2c.c...
context.c:135:13: warning: ‘context_print’ defined but not used [-Wunused-function]
  135 | static void context_print()
      |             ^~~~~~~~~~~~~
rtdb_seq.c: In function ‘ma_print’:
rtdb_seq.c:137:33: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘Integer’ {aka ‘long int’} [-Wformat=]
  137 |       nprint += fprintf(file, "%d ", ((Integer *) p)[i]);
      |                                ~^    ~~~~~~~~~~~~~~~~~~
      |                                 |                   |
      |                                 int                 Integer {aka long int}
      |                                %ld
rtdb.c: In function ‘rtdb_broadcast’:
rtdb.c:91:11: warning: unused variable ‘type’ [-Wunused-variable]
   91 |   Integer type = msg_type;
      |           ^~~~
rtdb.c: At top level:
rtdb.c:179:25: warning: argument 2 of type ‘char *’ declared as a pointer [-Warray-parameter=]
  179 |                   char* fname)
      |                   ~~~~~~^~~~~
In file included from rtdb.c:4:
rtdb.h:145:38: note: previously declared as an array ‘char[36]’
  145 | extern int rtdb_getfname(const int,  char [36]);
      |                                      ^~~~~~~~~
context_f2c.c: In function ‘string_to_fortchar’:
context_f2c.c:69:12: warning: old-style function definition [-Wold-style-definition]
   69 | static int string_to_fortchar( f, flen, buf)
      |            ^~~~~~~~~~~~~~~~~~
rtdb_seq.c: At top level:
rtdb_seq.c:1192:25: warning: argument 2 of type ‘char *’ declared as a pointer [-Warray-parameter=]
 1192 |                   char* fname)
      |                   ~~~~~~^~~~~
In file included from rtdb_seq.c:42:
rtdb.h:166:42: note: previously declared as an array ‘char[36]’
  166 | extern int rtdb_seq_getfname(const int,  char [36]);
      |                                          ^~~~~~~~~
make[4]: Leaving directory '/build/reproducible-path/nwchem-7.2.3/build-openmpi/src/rtdb'
Compiling hdbm.c...
hdbm.c: In function ‘delete_file_entry’:
hdbm.c:610:9: error: expected identifier or ‘(’ before ‘false’
  610 |     int false = 0;
      |         ^~~~~
hdbm.c:619:30: error: lvalue required as unary ‘&’ operand
  619 |     if (hdbm_fwrite((char *) &false, sizeof(false), (size_t) 1, file) != 1) {
      |                              ^
make[5]: *** [../../config/makefile.h:4015: /build/reproducible-path/nwchem-7.2.3/build-openmpi/lib/LINUX64/libnwcutil.a(hdbm.o)] Error 1
make[5]: Leaving directory '/build/reproducible-path/nwchem-7.2.3/build-openmpi/src/rtdb/hdbm'
make[4]: *** [../../config/makelib.h:146: optimized] Error 2
make[4]: Leaving directory '/build/reproducible-path/nwchem-7.2.3/build-openmpi/src/rtdb/hdbm'
make[3]: *** [../config/makelib.h:226: subdirs] Error 1
make[3]: Leaving directory '/build/reproducible-path/nwchem-7.2.3/build-openmpi/src/rtdb'
make[2]: *** [GNUmakefile:105: libraries] Error 1
make[2]: Leaving directory '/build/reproducible-path/nwchem-7.2.3/build-openmpi/src'
make[1]: *** [debian/rules:93: override_dh_auto_build-arch] Error 2
make[1]: Leaving directory '/build/reproducible-path/nwchem-7.2.3'
make: *** [debian/rules:79: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2