[Debichem-devel] pymatgen-core-test-files_2026.4.7-1_amd64.changes REJECTED

[Drew Parsons]

On 2026-04-17 01:00, Emmanuel Arias wrote:
> Thanks for your contributions to Debian! I leave some comments:
> 
> - Please consider the copyright note in central_diff_weights in
>   tests/core/elasticity/test_elastic.py file
> - tests/util/test_graph_hashing.py Seems to be BSD-3-Clause.
> - Please, consider use Expat license instead of MIT license.
> - d/copyright excluded files/folder but the source version has no 
> repack suffix.
> - Please mention test-files/cif/Cu7Te5.cif copyright
> - Please mention test-files/io/abinit/* copyright
> - Seems test-files/io/qchem/new_qchem_files/* copright should be 
> mentioned.
> 
> Further information may be found at:
>    https://dfsg-new-queue.debian.org/reviews/pymatgen-core-test-files
> 
> Regards, Emmanuel Arias


Thanks for the scrutiny, Emmanuel.

With regards to the MIT licence, LICENSE declares:

Copyright (c) 2011-2012 MIT & The Regents of the University of 
California,

So this software literally does belong to MIT.  I don't think it's 
reasonable to call it "Expat" instead of "MIT" when it literally does 
come from MIT.

I'll apply the other copyright updates.

Drew