<div dir="ltr"><div><div>Hi Michael<br><br></div>Since your last email I've made many changes to my p4vasp packaging [1] and I think it is ready for review and hopefully for upload too.<br></div><div><div><div><div class="gmail_extra">
<br><div class="gmail_quote">On 16 March 2014 14:18, Michael Banck <span dir="ltr"><<a href="mailto:mbanck@debian.org" target="_blank">mbanck@debian.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I concur about shipping it as one application for now, this also lets us<br>
ignore what to do about the forked odpdom for now.<br></blockquote><div><br></div><div>I went ahead and prepared it as a single binary package.<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
You talk about API documentation above, but I don't see any in the .deb<br>
I built, did that get stripped again or is this some in-app feature with<br>
a non-standard location?<br></blockquote><div><br></div><div>I ended up repacking the source tarball, excluding the API documentation and a couple of other files we don't need (trimming it down to 1/10 of its original size).<br>
</div><div>If we ever decide to ship the API documentation in future, we would build it using epydoc and doxygen as upstream do anyway.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
If this is a self-contained application package, it might be useful not<br>
to ship the API documentation anyway, until there are users of it and/or<br>
the library/API is split off into its own package. But that's your<br>
call.<br>
<br>
Same goes for the header files. I see you remove the .a static<br>
libraries, but then the header files serve no purpose either, because<br>
you can include them, but not link anything in.<br></blockquote><div><br></div><div>API documentation and header files are no longer included.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I am not sure about the location of _cp4vasp.so. This is a python<br>
extension module in C, not a C library really, I guess. Currently you<br>
put it in /usr/lib, but I would say it should be moved to<br>
/usr/lib/python$(PYVERSION)/dist-packages or so, see e.g. the top of<br>
<a href="https://packages.debian.org/sid/amd64/python-bzrlib/filelist" target="_blank">https://packages.debian.org/sid/amd64/python-bzrlib/filelist</a> (the ones<br>
in pyshared are symbolic links to ../../python$(PYVERSION)/dist-packages<br>
AFAICT). See also the python-avogadro package as an example.<br></blockquote><div><br></div><div>I moved _cp4vasp.so as you suggested.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
1. Too bad there are no example files shipped, but with those non-free<br>
codes, I guess it might be difficult to ship them anyway. Maybe input<br>
files would be fine, you could maybe talk to upstream about this.<br></blockquote><div><br></div><div>There is a nice tutorial [2] on upstream's website, as well as an example [3] for download.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
2. As I don't have access to VASP, I couldn't really test it out. What<br>
I noted is that the sqlite database setup is not very straight-forward -<br>
...<br>
This is likely an upstream problem, but I thought I'd mention it here.<br></blockquote><div><br></div><div>I did mention this to upstream and apparently a rewrite of the database and applet layer is planned for the migration to python3.<br>
<br></div><div>Regards<br>Graham<br></div><div> <br></div><div>[1] <a href="http://anonscm.debian.org/gitweb/?p=debichem/packages/p4vasp.git">http://anonscm.debian.org/gitweb/?p=debichem/packages/p4vasp.git</a> <br>[2] <a href="http://www.p4vasp.at/index.php/documentation/7-exploring-density-of-states-dos-and-band-structure">http://www.p4vasp.at/index.php/documentation/7-exploring-density-of-states-dos-and-band-structure</a><br>
[3] <a href="http://www.p4vasp.at/index.php/downloads/summary/1-examples/2-ldos">http://www.p4vasp.at/index.php/downloads/summary/1-examples/2-ldos</a><br><br></div></div></div></div></div></div></div>