[Filesystems-devel] Bug#793863: Improved patch available

[Vincent Cheng]

On Sat, Aug 1, 2015 at 11:38 AM, 殷啟聰 <seamlikok at gmail.com> wrote:
> Hi,
>
> During the work on Android SDK I corrected some compiler flags for
> libf2fs_format.so, please consider this improved patch. You can also
> view the patch at
> <https://github.com/seamlik/debianpkg-f2fs-tools/compare/master...modify-autotools>.
> Thank you.

Sorry for the late reply!

Your patch seems to cause f2fs-tools to FTBFS in a pbuilder chroot
(see attached build log for the full log):

   dh_install
debian/tmp/sbin/dump.f2fs: error while loading shared libraries:
libf2fs.so.1: cannot open shared object file: No such file or
directory
dh_install: problem reading debian/f2fs-tools.install:
debian/rules:7: recipe for target 'binary' failed


Also, your patch introduces the following diff in d/rules:
- dh_auto_configure -- --bindir=/sbin --libdir=/lib/$(DEB_HOST_MULTIARCH)
+ dh_auto_configure -- --bindir=/sbin --libdir=/lib

Why did you drop $(DEB_HOST_MULTIARCH) from being passed to --libdir,
and then manually move various files into multiarch-compatible paths
using dh_install and dh-exec? Also, why move files from /sbin ->
/usr/sbin and /lib -> /usr/lib? That seems to be an unnecessary
change.

Regards,
Vincent
-------------- next part --------------
A non-text attachment was scrubbed...
Name: f2fs-tools_1.4.1-2_amd64.build
Type: application/octet-stream
Size: 40874 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/filesystems-devel/attachments/20150821/84cbaa77/attachment-0001.obj>