[Filesystems-devel] Bug#843846: Bug#843846: aufs for 4.8: "../fs/mount.h not found" when enabling NFS export
sfjro at users.sourceforge.net
sfjro at users.sourceforge.net
Mon Nov 21 16:00:30 UTC 2016
Philipp Marek:
> But fs/mount.h does
>
> #include <linux/mount.h>
>
> and it seems that the linux/mount.h contains everything that AUFS needs.
>
>
> I've got the module up and running for a few hours, mounting/unmounting
> directories all the time (in a testsuite)... so it looks as if it's not
> _completely_ broken ;)
Sorry for the long delay.
This "aufs is compiled and working" news surprised me, and I digged down
the git log to find out why fs/mount.h is necessary.
And here is the fix which will be included in next aufs release.
Thanx for reporting, two of you.
J. R. Okajima
commit 348da45314afe6fc88e6f91a74da4587ec6555af
Author: J. R. Okajima <hooanon05g at gmail.com>
Date: Tue Nov 22 00:51:45 2016 +0900
aufs: dependency bugfix, linux/fs/mount.h
linux/fs/mount.h is included from two aufs source files,
fs/aufs/export.c and fs/aufs/vfsub.c.
For export.c, it is unnecessary which means a build dependency bug. The
bug was born back in 2012.
c70a5cf 2012-01-13 aufs: tiny for 3.3, arg for iterate_mounts()
For vfsub.c, it is necessary and it is not a bug. But it is just for
CONFIG_AUFS_BR_FUSE only. So it should be refined by "#ifdef
CONFIG_AUFS_BR_FUSE".
Reported-by: Jan Luca Naumann <j.naumann at fu-berlin.de>
See-also: https://github.com/sfjro/aufs4-standalone/pull/1
Reported-by: Philipp Marek <philipp.marek at linbit.com>
See-also: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=843846
Signed-off-by: J. R. Okajima <hooanon05g at gmail.com>
diff --git a/fs/aufs/export.c b/fs/aufs/export.c
index 2b2380a..afba472 100644
--- a/fs/aufs/export.c
+++ b/fs/aufs/export.c
@@ -12,7 +12,6 @@
#include <linux/nsproxy.h>
#include <linux/random.h>
#include <linux/writeback.h>
-#include "../fs/mount.h"
#include "aufs.h"
union conv {
diff --git a/fs/aufs/vfsub.c b/fs/aufs/vfsub.c
index f2d1b36..fc52351 100644
--- a/fs/aufs/vfsub.c
+++ b/fs/aufs/vfsub.c
@@ -10,7 +10,9 @@
#include <linux/nsproxy.h>
#include <linux/security.h>
#include <linux/splice.h>
+#ifdef CONFIG_AUFS_BR_FUSE
#include "../fs/mount.h"
+#endif
#include "aufs.h"
#ifdef CONFIG_AUFS_BR_FUSE
More information about the Filesystems-devel
mailing list