[Fingerforce-devel] Bug#997667: fprintd: max_tries argument should instead be max-tries

[John Colvin]

Package: fprintd
Version: 1.90.9-1build1
Severity: normal
X-Debbugs-Cc: john.loughran.colvin at gmail.com

Dear Maintainer,

Sorry if I do something wrong here, I've never submitted a bug to debian
before. I am acutally running kubuntu but I'm pretty sure the bug is
deeper down the stack. It may even be deeper than debian!

pam-auth-updates, when asked to enable fingerprint auth, sets an
argument max_tries=1 to the fprintd module. This is the wrong name for
the option (perhaps a misunderstanding from old release notes, see 
https://gitlab.freedesktop.org/libfprint/fprintd/-/merge_requests/164),
the correct form would be max-tries=1

I couldn't find any matching strings in pam-auth-updates, but I was able
to find
https://salsa.debian.org/debian/fprintd/-/blob/0b7353bcd7ebd8d307dad44e73276e67271f67ec/debian/pam-configs/fprintd
which seems to have the same mistake. Maybe that is where the bug truly
is?

That was added in
https://salsa.debian.org/debian/fprintd/-/commit/d90232eaf6ce050ed494d9fb9cd8464ba595468f
which appears to be from a debian patch to fprintd adding max_tries
(note the underscore) as an option. Then in
https://salsa.debian.org/debian/fprintd/-/commit/b8b886550e3f4e3392d50ca03fb5a94244ebcbc6
when the upstream implementation was adopted - which used max-tries as
the option name - the change wasn't reflected in pam_configs/fprintd.

As I mentioned on the upstream MR I made, this might seem relatively
innocuous, but it does mean a lot of systems out there might be using
the default (3 for now) instead of the 1 expected.

I suppose I should submit a patch, but I don't really understand the
process here yet. Can I just make an MR on salsa.debian.org?


-- System Information:
Debian Release: 11.0
  APT prefers impish-updates
  APT policy: (500, 'impish-updates'), (500, 'impish-security'), (500, 'impish')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.13.0-20-generic (SMP w/16 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages fprintd depends on:
ii  dbus                   1.12.20-2ubuntu2
ii  libc6                  2.34-0ubuntu3
ii  libfprint-2-2          1:1.90.7+git20210222+tod1-0ubuntu3
ii  libglib2.0-0           2.68.4-1ubuntu1
ii  libpolkit-gobject-1-0  0.105-31
ii  policykit-1            0.105-31

fprintd recommends no packages.

fprintd suggests no packages.

-- no debconf information