[Freedombox-discuss] First review comments on plinth from the Debian ftpmasters (rejected)

[James Valleroy]

> It appears you're shipping sourcelss minified javascript. Please
> depend on the proper packages and add links or ship source. The
> former is very much prefered.
>
> Examples include:
>  html5.js
>  jquery-1.7.1.min.js
>  lib~odernizr-2.5.3-respond-1.1.0.min.js

Are we actually using these scripts anywhere? A quick check with grep
shows only templates/base.tmpl and templates/base.py reference these
scripts:

jvalleroy at fbx:~/src/Plinth$ grep -R html5.js .
./templates/base.tmpl:    <script type="text/javascript"
src="$basehref/static/theme/js/libs/html5.js"></script>
./templates/base.py:        write(u'''/static/theme/js/libs/html5.js"></script>
grep: warning: ./static/static: recursive directory loop

jvalleroy at fbx:~/src/Plinth$ grep -R jquery-1.7.1.min.js .
./templates/base.tmpl:    <script type="text/javascript"
src="$basehref/static/theme/js/libs/jquery-1.7.1.min.js"></script>
./templates/base.py:
write(u'''/static/theme/js/libs/jquery-1.7.1.min.js"></script>
grep: warning: ./static/static: recursive directory loop

jvalleroy at fbx:~/src/Plinth$ grep -R modernizr-2.5.3-respond-1.1.0.min.js .
./templates/base.tmpl:    <script type="text/javascript"
src="$basehref/static/theme/js/libs/modernizr-2.5.3-respond-1.1.0.min.js"></script>
./templates/base.py:
write(u'''/static/theme/js/libs/modernizr-2.5.3-respond-1.1.0.min.js"></script>
grep: warning: ./static/static: recursive directory loop

Checking what references base.tmpl, I see a bunch of documentation and
and a single reference in templates/base.py. And it appears that no
files are referencing base.py.

Am I missing anything with regards to how these files are used?

--
James Valleroy