[Freedombox-pkg-team] Bug#990758: freedombox: please add Breaks: fuse (<< 3) and Depends: fuse3 (>= 3)

[Andreas Beckmann]

Package: freedombox
Version: 21.4.2
Severity: serious
Tags: patch
User: debian-qa at lists.debian.org
Usertags: piuparts

Upgrading freedombox from buster to bullseye requires to replace fuse
with fuse3 in order to install sshfs.
Since there is no clean upgrade path for fuse -> fuse3 (#918984, will
not be fixed for bullseye but only for bookworm), we need to add some
Breaks/Depends elsewhere to make this switch happen without requiring
manual interaction.

Here is an excerpt of the diff of the apt problem resolution from
an upgrade of buster to
  a) current bullseye (which does not upgrade freedombox at all) and
  b) a bullseye with freedombox and sshfs patched to carry more Depends/Breaks.
The apt scores change from 'preferring to keep fuse installed' to 'switching to fuse3'.

...
-  Starting 2 pkgProblemResolver with broken count: 12
+  Starting 2 pkgProblemResolver with broken count: 14
...
-  Investigating (0) fuse3:amd64 < none -> 3.10.3-2 @un uN Ib >
-  Broken fuse3:amd64 Breaks on fuse:amd64 < 2.9.9-1+deb10u1 -> 2.9.9-5 @ii umU >
-    Considering fuse:amd64 4 as a solution to fuse3:amd64 2
-    Holding Back fuse3:amd64 rather than change fuse:amd64
-  Investigating (0) sshfs:amd64 < none -> 3.7.1+repack-1 @un uN Ib >
-  Broken sshfs:amd64 Depends on fuse3:amd64 < none | 3.10.3-2 @un uH >
-    Considering fuse3:amd64 2 as a solution to sshfs:amd64 0
-    Holding Back sshfs:amd64 rather than change fuse3:amd64
-  Investigating (0) freedombox:amd64 < 19.1+deb10u2 -> 21.4.2 @ii umU Ib >
-  Broken freedombox:amd64 Depends on sshfs:amd64 < none | 3.7.1+repack-1 @un uH >
-    Considering sshfs:amd64 0 as a solution to freedombox:amd64 0
-    Holding Back freedombox:amd64 rather than change sshfs:amd64
+  Investigating (0) fuse3:amd64 < none -> 3.10.3-2 @un uN Ib >
+  Broken fuse3:amd64 Breaks on fuse:amd64 < 2.9.9-1+deb10u1 -> 2.9.9-5 @ii umU >
+    Considering fuse:amd64 2 as a solution to fuse3:amd64 3
+    Added fuse:amd64 to the remove list
+    Conflicts//Breaks against version 2.9.9-1+deb10u1 for fuse but that is not InstVer, ignoring
+    Fixing fuse3:amd64 via remove of fuse:amd64
...
-   Try to Re-Instate (1) freedombox:amd64
   Done
...
   The following packages will be REMOVED:
-    g++-8 gcc-8 libgc1c2 libgcc-8-dev libpolkit-backend-1-0 libpython-stdlib
-    libstdc++-8-dev php7.3-cli php7.3-common php7.3-fpm php7.3-json
-    php7.3-opcache php7.3-readline python python-django-common python-minimal
-    python-pyicu python3.7
+    fuse g++-8 gcc-8 libgc1c2 libgcc-8-dev libpolkit-backend-1-0
+    libpython-stdlib libstdc++-8-dev php7.3-cli php7.3-common php7.3-fpm
+    php7.3-json php7.3-opcache php7.3-readline python python-django-common
+    python-minimal python-pyicu python3.7
...
-  The following packages have been kept back:
-    freedombox
...
-  532 upgraded, 119 newly installed, 18 to remove and 1 not upgraded.
+  532 upgraded, 186 newly installed, 19 to remove and 0 not upgraded.

Please see the attached patch.


Andreas
-------------- next part --------------
diff -Nru freedombox-21.4.2/debian/changelog freedombox-21.4.2+nmu1~deb11anbe3/debian/changelog
--- freedombox-21.4.2/debian/changelog	2021-03-28 15:23:46.000000000 +0200
+++ freedombox-21.4.2+nmu1~deb11anbe3/debian/changelog	2021-07-01 12:43:04.000000000 +0200
@@ -1,3 +1,10 @@
+freedombox (21.4.3) UNRELEASED; urgency=medium
+
+  * freedombox: Add Breaks: fuse (<< 3) and Depends: fuse3 (>= 3) to ensure
+    fuse gets replaced by fuse3 on upgrades from buster.  (Closes: #-1)
+
+ -- Andreas Beckmann <anbe at debian.org>  Thu, 01 Jul 2021 12:43:04 +0200
+
 freedombox (21.4.2) unstable; urgency=high
 
   [ Burak Yavuz ]
diff -Nru freedombox-21.4.2/debian/control freedombox-21.4.2+nmu1~deb11anbe3/debian/control
--- freedombox-21.4.2/debian/control	2021-03-28 15:23:46.000000000 +0200
+++ freedombox-21.4.2+nmu1~deb11anbe3/debian/control	2021-07-01 12:43:04.000000000 +0200
@@ -58,6 +58,8 @@
 Breaks:
  freedombox-setup (<< 0.13~),
  plinth (<< 0.46.0~),
+# Ensure fuse gets replaced by fuse3 on upgrades from buster s.t. sshfs can be installed.
+ fuse (<< 3),
 Replaces:
  freedombox-setup (<< 0.13~),
  plinth (<< 0.46.0~),
@@ -116,6 +118,8 @@
  python3-yaml,
  sudo,
  wget,
+# Ensure fuse gets replaced by fuse3 on upgrades from buster s.t. sshfs can be installed.
+ fuse3 (>= 3),
 Recommends:
 # Priority: standard
  bzip2,