[Fusioninventory-devel] Proposed enhancements/corrections

[Oliver Tuschhoff]

Dear FusionInventory-Team,

thank you for providing such a great piece of software. While deploying the
Agent into our environment I had to make several enhancements/corrections
which I wanted to give back (against Version 2.1.10):

fusioninventory-win32-service.patch:
Correcting the name of a utilized function of the Win32::Daemon package from
LastControlMessage() to QueryLastMessage().
The change in the underlying package seems to have happened in version
20101014 and is still current (
http://cpansearch.perl.org/src/JDB/Win32-Daemon-20110117/Changes).

solaris-plugins-zonename.patch:
While calling zonename to detect the zone-type, a newline-char (outputted by
zonename) prevents the correct detection.
The proposed patch sanitizes the output of zonename by piping its output
into tr -d [[:cntrl:]].
Affected solaris-plugins: CPU, Bios, Memory, Networks

solaris-network-plugin.patch:
While checking the autospeed-status of a bge network-adapter, the called
system-app (ndd) seems to be given bogus variables, which prevents correct
detection. The proposed patch aligns the variables of the affected call with
the rest of the plugin.

CPU.pm:
In our solaris-environment, the current CPU-plugin had severe problems
detecting the correct values. The proposed patch exchanges the whole
memconf-based
plugin for a kstat-based plugin. As an added benefit, the plugin-size and
complexity is severely shrunk.

The respective patches have been tested on:
- Windows 2003 R2/2008
- Solaris 10: x86/SPARC, global/local zone

I'd love to hear your feedback and would be thankful for including these
proposed patches.
Please notify me if I could be of any assistance.

Best regards,
Oliver Tuschhoff

-- 
Oliver Tuschhoff - Beratung und Training
Steinackerstr. 17, 64285 Darmstadt
Tel.:      +49 176 2378 0610
E-Mail:  mail at oliver-tuschhoff.de
Skype:  oliver.tuschhoff
URL:     www.oliver-tuschhoff.de
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/fusioninventory-devel/attachments/20111004/4d6d8ccd/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CPU.pm
Type: application/octet-stream
Size: 1220 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/fusioninventory-devel/attachments/20111004/4d6d8ccd/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fusioninventory-win32-service.patch
Type: application/octet-stream
Size: 641 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/fusioninventory-devel/attachments/20111004/4d6d8ccd/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: solaris-network-plugin.patch
Type: application/octet-stream
Size: 545 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/fusioninventory-devel/attachments/20111004/4d6d8ccd/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: solaris-plugins-zonename.patch
Type: application/octet-stream
Size: 1608 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/fusioninventory-devel/attachments/20111004/4d6d8ccd/attachment-0003.obj>