[libhid-discuss] [patch] Timeout error codes, deb packaging

Charles Lepple clepple at ghz.cc
Wed Feb 28 04:44:33 CET 2007


On Feb 26, 2007, at 8:29 PM, Andreas Klöckner wrote:

> Hi Charles, *,
>
> please find attached a patch (against current svn) that  
> accomplishes the
> following:
>
> - Add an error code HID_RET_TIMEOUT that is returned from  
> hid_interrupt_* if a
> timeout is encountered. This makes it possible to tell failures and  
> timeouts
> apart, which is sometimes important.
> - Fix up autogen.sh and swig/Makefile.am so that they work with  
> current
> autotools.
> - Update debian/* to include the most recent changes to the debian  
> package.
> - Update hidwrap.py to take advantage of hid_strerror, eliminating  
> a good
> chunk of duplicated code.
>
> Let me know if there are any issues.

Looks good, except for the autogen.sh patch.

1) The pipeline that first tries 1.9 and then 1.8 is intentional -  
Debian and Ubuntu systems seem to have automake-1.4 installed as the  
default.

2) the "exec configure" line is meant to emulate autoreconf  
(actually, I'm not sure why we can't just use autoreconf...)

I applied everything else, broken up into smaller chunks so that I  
can debug my local swig config issues more easily. I realize I still  
have one of your patches sitting in my mailbox, and that is also due  
to running out of time while tracking down swig issues.

Patch follows for reference.

--- autogen.sh  (revision 311)
+++ autogen.sh  (working copy)
@@ -1,11 +1,11 @@
#!/bin/sh -ex
libtoolize --force &> /dev/null
-aclocal-1.9 -I m4 || aclocal-1.8 -I m4 || aclocal -I m4
+aclocal -I m4
autoheader
-automake-1.9 --add-missing || automake-1.8 --add-missing || automake  
--add-missing
+automake --add-missing --foreign
autoconf
-exec ./configure "$@"
+#exec ./configure "$@"
# COPYRIGHT --
#


-- 
Charles Lepple
clepple at ghz.cc





More information about the libhid-discuss mailing list