[PATCH] New function: find_k_nearest()
Willi Richert
w.richert at gmx.net
Tue Mar 31 15:40:24 UTC 2009
On Dienstag 31 März 2009 17:09:41 martin f krafft wrote:
> also sprach Willi Richert <w.richert at gmx.net> [2009.03.31.1656 +0200]:
> > New function: find_k_nearest()
> >
> > Besides:
> > - better checks for memory leaks in swig
> > - cleaned Makefile
> > - better Python tests
> > - fixed C++ test file
>
> Is there any reason you didn't make at least five separate commits?
> I find huge, monolithic commits like this, which incorporate
> multiple *independent* changes to be very hard to process.
>
> Generally, one commit should have one logical change and be
> self-contained, meaning that it the feature must later work. This
> includes test code, documentation, etc.
Of course I can do that. As my patches are not directly going into the master
branch I though that it is easier for those you only listen to the master
branch.
Thanks for the hint.
Regards,
wr
More information about the libkdtree-devel
mailing list