<br><br><div class="gmail_quote">2009/12/6 Jason Remillard <span dir="ltr"><<a href="mailto:remillard.jason@gmail.com">remillard.jason@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi Paul,<br>
<br>
I pulled your git tree (at least I think) and updated the comments.<br>
The find_within_range is not using the manhattan distance metric, but<br>
rather an absolute distance metric. (what I meant by _abs) function.<br></blockquote><div><br></div><div>What is your definition of manhattan distance metric? is it not an absolute distance metric? i think my terminology doesn't match yours</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Nothing wrong with that, it is very fast. It just needs to be<br>
documented. The patch changes the comment, and adds in some more<br>
information that confused me when I first started using the library. I<br>
also took a stab at commenting the optimize function which also<br>
confused me when I was starting out.<br>
<br></blockquote><div><br></div><div>Have a closer look at efficient_replace_and_optimise() or whatever i named it. better than normal optimise(), because YOU (The user) can supply a vector<> that it will use as its working space (which means the vector will be messed up), but it means it skips an additional copy, ie:</div>
<div><br></div><div>optimise( container ) // the normal one<br>{</div><div> temp_vector; // skipped<br> copy(container --> temp_vector); // skipped</div><div> sort_and_insert(temp_vector);</div><div>} </div><div>
<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I have not used git before, so hopefully the patch works.<br>
<br>
Thanks<br>
<font color="#888888">Jason.<br>
</font><div><div></div><div class="h5"><br></div></div></blockquote><div><br></div><div>looks ok when i glanced at it, but i have to go out now. keep poking around please :)</div><div><br></div><div>Paul</div><div><br></div>
</div>