<br><br><div class="gmail_quote">2009/12/6 Jason Remillard <span dir="ltr"><<a href="mailto:remillard.jason@gmail.com">remillard.jason@gmail.com</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br>
<br>
I am one of the users that has been caught by the find_within_range<br>
functions :-)<br>
<br></blockquote><div><br>Hi Jason,<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Breaking peoples code is kind of drastic. A simple comment above each<br>
find functions would have prevented any confusion on my part.<br>
<br></blockquote><div><br>True. My biggest concern is the welfare of those programmers who have been caught but are unaware. A comment will save future users from harm, but not the current users.<br><br>I find the biggest confusion is that you can do<br>
find_within_range(point,distance)<br><br>which converts it into <br>find_within_range( box_shaped_region )<br> <br>The point-distance function is deceptive, with or without a comment. That is what I was hoping to kill off.<br>
<br><br>Like you said, maybe we just need to add comments, better documentation, and a big "warning" on the webpage and ChangeLog or something like that. If a developer upgrades without checking what changes were made, then ... their loss I guess.<br>
<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Just add in the new functions (I assume they look something like this)<br>
<br>
find_within_range_abs<br></blockquote><div><br>I don't understand what this function would do... ?<br>Any distance measurement must be absolute, no? Unless you are searching based on a point+direction (ie a vector) or something funky like that.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
find_within_range_manhattan<br>
find_within_range_euclidean<br>
<br></blockquote><div><br>These I understand, and I like the naming (although "manhattan" is known by many names like "taxi distance" or "city block" etc etc).<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Just leave find_within_range in place, and have it be a simple one<br>
line function calling one of the new functions. It is pretty much<br>
impossible to use the class without looking in the header file, so it<br>
will be crystal clear to everybody what is going on when using the new<br>
release. Now if the plan is to not support abs distance, then you<br>
should kill the function rather than changing the systematics.<br>
<br></blockquote><div><br>thanks for your comments :)<br>Paul<br></div></div><br>