[Nut-upsdev] Re: adding libusb CFLAGS to generic-hid.c rule

[Peter Selinger]

OK, I have committed these changes. -- Peter

Charles Lepple wrote:
> 
> On 11/8/05, Peter Selinger <selinger at mathstat.dal.ca> wrote:
> > Hi Charles,
> >
> > I think this was a typo anyway; it should have always been <usb.h>,
> > right? We don't supply usb.h in the build directories.
> 
> agreed.
> 
> > All the sources that include libusb.h or libhid.h should have a
> > dependency on $(LIBUSB_CFLAGS). This is not just generic-hid.o (as in
> > your patch), but actually all the *-hid.o files, and more.
> 
> hmm, odd that the other *-hid.o files compiled fine without it. But
> you're right, they should all have the same CFLAGS.
> 
> > Also, the $(LIBUSB_CFLAGS) is unnecessary during linking, so I have
> > removed it from those Makefile lines that are linking commands.
> >
> > I am enclosing a patch for how I think it should be done. Let me know
> > if any of this breaks on OS X or does not suit you.
> 
> It gets a big thumbs-up from me.
> 
> --
> - Charles Lepple
>