[Nut-upsdev] Re: [resend] Re: [resend] [patch] driver for Eltek

[Peter Selinger]

Kirill Smelkov wrote:
> 
> > > Although in my ups there are 3 states:
> > >
> > > LB -- low battery
> > > HB -- high battery
> > > ?? -- normal battery (?? = NB)
> > >
> > > Maybe it is worth extending status semantic?
> > - we already have LB
> > - normal battery is represented by the absence of LB/RB
> > - HB should stand for OL+battery.charge=100 isn't it?!
> I think "High Battery" is not "Normal Battery"
> The doc i have says:
> 
> Battery voltage status
> ============
> 0:  normal
> 1:  low battery
> 2:  high battery
> 
> Do you see?
> 
> > You should better add support for battery.charge. Your ups supports
> > battery.{current, temperature,...} so it really should support it, and the
> > status extension is not needed at all.
> I would be *very happy* to do that, but AL175 *lacks* support for 
> battery.charge!

Hm. I still think "HB" does not really belong in the status flags
(although it could not actually hurt anything, I think).  Perhaps your
driver can supply a symbolic value to battery.charge, i.e.,
battery.charge=100 or 50 or 0?

-- Peter