[Nut-upsdev] Status of the PSE NUT patches (was: NUT patches)

Peter Selinger selinger at mathstat.dal.ca
Fri Sep 9 22:17:11 UTC 2005


arnaud.quette at mgeups.com wrote:
> 
> 
> Here is the status of PSE (Peter Selinger) NUT patches
> for newhidups (hidparser, apc support, ...).
> 
> - nut-cvs-patch-REOPEN-2005-08-24:
> approved and applied on Development tree
> Notes: - avoid cpp style comment
>             - I don't see the difference as we return when
>       the driver unbind has been done. You'll only get
>       again the mfr,model and serial strings! Or maybe
>       that was previous to my change to it (move after
>       unbind)...

You are right; when I made this change, the order of the operations
was different. Still, I think there are some benefits to repeating all
the "open" steps when "reopening" a device; for example, if a serial
number is found, but is not equal to that of the previous device, we
can search for the device with the correct serial number. This should
be reasonably accurate for ensuring that the same device is reopened,
in case someone has more than one device attached. 

> - nut-cvs-patch-DEP-2005-08-24:
> not applied. I'd like to have something more generic, along
> with the gendb system, that will declare some base deps
> (ie "main.h dstate.h serial.h" for serial drivers), and a @.h
> one (need to have a .h for every driver). Then, there will
> be the special cases (usb, snmp, ... drivers)

A permanent solution would be very nice. In the meantime, the complete
absence of useful dependencies is annoying, especially as they can be
generated automatically.

> > * ups.test.panel / Panel test / 0
> >
>   > My APC UPS has a "panel test" variable, which consists of a single
>   > R/W bit. .....
> 
>   I've not kept this one. We'll have to speak / audit a bit
>   more before applying...

That variable is useless anyway. I think it should probably be removed
permanently, until some other UPS model comes along and needs it.

-- Peter



More information about the Nut-upsdev mailing list