[Nut-upsdev] Re: [resend] [patch] driver for Eltek AL175 alarm module

[Arnaud Quette]

Hi Kirill,


Attached is my patch to add support for AL175 alarm module,
> Please ACK or NAK this. 
> 
> 
there are some things that need to be reworked:

* variables: 
(see http://eu1.networkupstools.org/doc/2.0.1/new-names.html)
all the below vars are non standard. what do you put in all of these?
thanks to detail back, as in new names.

- load.fuse
- battery.fuse
- symalarm.fuse
- battery.contactor
- load.contactor
- lvd.contactor

* load.current: this var doesn't exist! If it's the output current, then the 
right var is output.current. <http://driver.name>
* driver.name <http://driver.name> is already published by the core (main.c), 
so you can remove it.
* you should use the internal xmalloc() function
* please send your diff in unified format (diff -Nru orig.tree modified.tree
)
* the driver's manpage is missing (al175.8)

More generally, please read the following to ensure you comply with NUT 
standard for coding, variables names, ... :
http://eu1.networkupstools.org/doc/2.0.1/developers.html
http://eu1.networkupstools.org/doc/2.0.1/new-drivers.html
http://eu1.networkupstools.org/doc/2.0.1/new-names.html

Please, correct the above, and discuss on upsdev the variables problem...

Thanks for your contribution,
Arnaud 
-- 
Linux / Unix Expert - MGE UPS SYSTEMS - R&D Dpt
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer -
http://people.debian.org/~aquette/<http://people.debian.org/%7Eaquette/>
OpenSource Developer - http://arnaud.quette.free.fr/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20050920/2425e1d9/attachment.htm