[Nut-upsdev] New default for SNMP and USB (and HAL) compilation

[Charles Lepple]

On 12/28/06, Charles Lepple <clepple at gmail.com> wrote:
> On 12/28/06, Peter Selinger <selinger at mathstat.dal.ca> wrote:
> > * make distcheck now works, HAL and all.
>
> Hmm, 'make distcheck' now fails for me on OS X because I don't have
> hiddev. It will probably fail later because I don't have HAL. Could we
> have distcheck use '--with-all=auto' instead? I realize this makes
> distcheck slightly less all-encompassing, but that would make it
> useful on platforms other than Linux.

(the above still stands, though)

> > * the checks for libusb, libhal, and libnetsnmp are performed even if
> >   the corresponding --without options are given. This is because we
> >   have no good way of checking which drivers the user selected with
> >   --with-drivers=xxx,yyy,zzz, and these drivers might need the
> >   libraries.
>
> With SVN rev 658, "--with-hal=no" doesn't seem to prevent the system
> from building main-hal.c:

Looks like this was just a simple fix (committed as rev 661; revert or
change as necessary):

Index: drivers/Makefile.am
===================================================================
--- drivers/Makefile.am (revision 660)
+++ drivers/Makefile.am (working copy)
@@ -191,9 +191,11 @@
 # for object files. This library is used during the build process,
 # and is not meant to be installed.

+if WITH_HAL
 noinst_LIBRARIES = libnuthalmain.a
 libnuthalmain_a_SOURCES = main-hal.c dstate-hal.c
 libnuthalmain_a_CFLAGS = $(AM_CFLAGS) $(LIBHAL_CFLAGS)
+endif

 EXTRA_DIST = Doxyfile



-- 
- Charles Lepple